Add additional info and formatting to transaction command #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-vball
requested review from
michaelkaplan13,
cam-schultz,
minghinmatthewlam and
bernard-avalabs
as code owners
iansuvak
reviewed
Jun 17, 2024
cmd/teleporter-cli/transaction.go
Outdated
|
|
||
| for _, log := range receipt.Logs { | ||
| printTeleporterLogs(cmd, log) | ||
| printWarpLogs(cmd, log) |
There was a problem hiding this comment.
Did printWarpLogs(cmd,log) portion get tested? It looks like the cli-output.txt includes logs from the printTeleporterLogs portion only.
cam-schultz
reviewed
Jun 17, 2024
iansuvak
previously approved these changes
Jun 21, 2024
Co-authored-by: bernard-avalabs <[email protected]> Signed-off-by: Geoff Stuart <[email protected]>
cam-schultz
approved these changes
Jul 8, 2024
minghinmatthewlam
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Closes #400
How this works
Formats outputs using
json.MarshalIndentand prints them usingcmd.Println, sincelogger.Infocan only output to a single line.Adds an optional
-dor--debugflag to thetransactioncommand in the Teleporter CLI. This will output the transaction info and the transaction trace.How this was tested
Manually using
go build && ./teleporter-cli transaction --rpc 'https://testnet-qr0606t3tp-xe0ed.avax-test.network/ext/bc/rtLueJ1R8vQ7yGe3QdveWJB1VAnvusy6PPp7TrA5suhUmgbnB/rpc?token=<REDACTED>' -d --teleporter-address "0x253b2784c75e510dD0fF1da844684a1aC0aa5fcf" "0x23a6ab766838c3e0536e6630b8b07297716aaa2773869a80b62b2285b378007e"Output:
cli-output.txt (updated)
How is this documented
Adding info for command help