Simplify churn tracking

ava-labs · Sep 18, 2024 · eed92e4 · eed92e4
1 parent 2faa0af
commit eed92e4
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/abi-bindings/go/staking/ERC20TokenStakingManager/ERC20TokenStakingManager.go b/abi-bindings/go/staking/ERC20TokenStakingManager/ERC20TokenStakingManager.go
diff --git a/abi-bindings/go/staking/NativeTokenStakingManager/NativeTokenStakingManager.go b/abi-bindings/go/staking/NativeTokenStakingManager/NativeTokenStakingManager.go
diff --git a/abi-bindings/go/staking/PoAValidatorManager/PoAValidatorManager.go b/abi-bindings/go/staking/PoAValidatorManager/PoAValidatorManager.go
diff --git a/contracts/staking/ValidatorManager.sol b/contracts/staking/ValidatorManager.sol
@@ -434,7 +434,9 @@ abstract contract ValidatorManager is
             "ValidatorManager: maximum churn rate exceeded"
         );
 
-        churnTracker.totalWeight += newWeight - oldWeight;
+        // Two separate calculations because we're using uints and (newWeight - oldWeight) could underflow.
+        churnTracker.totalWeight += newWeight;
+        churnTracker.totalWeight -= oldWeight;
 
         $._churnTracker = churnTracker;
     }