Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pointcloud_preprocessor): parameter for distortion correction node #81

Conversation

vividf
Copy link
Contributor

@vividf vividf commented Nov 13, 2023

Description

This PR solves the issue autowarefoundation/autoware.universe#3896.
This PR adds a new parameter update_azimuth_and_distance for the distortion correction node to decide whether the user wants to update the azimuth and distance value.

Related links

Tests performed

Notes for reviewers

@drwnz
This PR corresponds to another PR (autowarefoundation/autoware.universe#5560) in autoware.universe. This PR should be updated with another PR at the same time.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@vividf vividf changed the title Feat/parameter for distortion correction node feat(pointcloud_preprocessor): parameter for distortion correction node Nov 13, 2023
Copy link

stale bot commented Jan 12, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the stale label Jan 12, 2024
@stale stale bot removed the stale label Mar 7, 2024
Copy link

stale bot commented May 6, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the stale label May 6, 2024
@vividf vividf marked this pull request as draft June 11, 2024 06:31
@stale stale bot removed the stale label Jun 11, 2024
Copy link

stale bot commented Aug 10, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the stale label Aug 10, 2024
@vividf vividf closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant