Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_launch): add centerpoint_sigma param #945

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

tzhong518
Copy link
Contributor

@tzhong518 tzhong518 commented Apr 4, 2024

Description

Add centerpoint_sigma.param.yaml

Related links

related PR to autoware.universe: autowarefoundation/autoware.universe#6573

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@tzhong518 tzhong518 changed the title add: centerpoint_sigma.param feat(autoware_launch): add centerpoint_sigma param Apr 4, 2024
@YoshiRi
Copy link
Contributor

YoshiRi commented Apr 4, 2024

Good.
I confirmed this model with sample rosbag in Tutorial.

image

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshiRi YoshiRi self-assigned this Apr 4, 2024
@YoshiRi YoshiRi merged commit f563ff7 into main Apr 4, 2024
13 of 15 checks passed
@YoshiRi YoshiRi deleted the feat/centerpoint_sigma branch April 4, 2024 16:21
4swinv pushed a commit to 4swinv/autoware_launch that referenced this pull request Apr 9, 2024
@miursh
Copy link
Contributor

miursh commented Apr 17, 2024

@tzhong518
Need to add has_variance param in pointpainting.param.yaml as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants