Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): tune lateral margin params #913

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Mar 11, 2024

Description

See autowarefoundation/autoware.universe#6520.

I tuned hard margin params for vehicle type object in public road test.

          lateral_margin:
            soft_margin: 0.3                           # [m]
            hard_margin: 0.2                           # [m]
            hard_margin_for_parked_vehicle: 0.7        # [m]
...
          envelope_buffer_margin: 0.5 

margin for parked vehicle

  • min: 1.2m (if the lateral margin less than this value, avoidance module inserts stop point until RTC is approved.)
  • max: 1.5m

margin for NON parked vehicle

  • min: 0.7m (if the lateral margin less than this value, avoidance module inserts stop point until RTC is approved.)
  • max: 1.0m

Tests performed

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@satoshi-ota satoshi-ota marked this pull request as ready for review March 11, 2024 07:44
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit df4d435 into autowarefoundation:main Mar 11, 2024
14 of 15 checks passed
@satoshi-ota satoshi-ota deleted the fix/tune-lateral-margin branch March 11, 2024 07:52
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Apr 8, 2024
4swinv pushed a commit to 4swinv/autoware_launch that referenced this pull request Apr 9, 2024
satoshi-ota pushed a commit to tier4/autoware_launch that referenced this pull request Jul 29, 2024
* chore(e2e_simulator): use normal rviz

Signed-off-by: Shumpei Wakabayashi <[email protected]>

* chore: rm awsim.rviz

Signed-off-by: Shumpei Wakabayashi <[email protected]>

---------

Signed-off-by: Shumpei Wakabayashi <[email protected]>
Ericpotato pushed a commit to tier4/autoware_launch that referenced this pull request Nov 6, 2024
* chore(e2e_simulator): use normal rviz

Signed-off-by: Shumpei Wakabayashi <[email protected]>

* chore: rm awsim.rviz

Signed-off-by: Shumpei Wakabayashi <[email protected]>

---------

Signed-off-by: Shumpei Wakabayashi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants