-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(component_state_monitor): monitor traffic light recognition output #720
Merged
TomohitoAndo
merged 1 commit into
autowarefoundation:main
from
TomohitoAndo:feat/monitor-traffic-signal-topic
Dec 5, 2023
Merged
feat(component_state_monitor): monitor traffic light recognition output #720
TomohitoAndo
merged 1 commit into
autowarefoundation:main
from
TomohitoAndo:feat/monitor-traffic-signal-topic
Dec 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomohito Ando <[email protected]>
4 tasks
miursh
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Dec 6, 2023
sykwer
pushed a commit
to sykwer/autoware_launch
that referenced
this pull request
Jan 3, 2024
…-autoware-launch feat: merge autowarefoundation/autoware_launch
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
Feb 6, 2024
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
May 21, 2024
* feat: tune condition of between cruise and stop (autowarefoundation#565) Tune condition of between cruise and stop * fix(traffic_light): stop if the traffic light signal timed out (autowarefoundation#727) (autowarefoundation#571) Signed-off-by: Fumiya Watanabe <[email protected]> Co-authored-by: Fumiya Watanabe <[email protected]> * feat(component_state_monitor): monitor traffic light recognition outp… (autowarefoundation#572) feat(component_state_monitor): monitor traffic light recognition output (autowarefoundation#720) Signed-off-by: Tomohito Ando <[email protected]> * update ground segmentation Signed-off-by: yoshiri <[email protected]> * update comparemap parameter Signed-off-by: yoshiri <[email protected]> * update clustering parameters Signed-off-by: yoshiri <[email protected]> * fix tracking iou threshold parameters Signed-off-by: yoshiri <[email protected]> * feat: set smaller threshold for euclidean clustering Signed-off-by: yoshiri <[email protected]> * chore: fit parameter for v3.0.0 Signed-off-by: yoshiri <[email protected]> --------- Signed-off-by: Fumiya Watanabe <[email protected]> Signed-off-by: Tomohito Ando <[email protected]> Signed-off-by: yoshiri <[email protected]> Co-authored-by: Shohei Sakai <[email protected]> Co-authored-by: Tomohito ANDO <[email protected]> Co-authored-by: Fumiya Watanabe <[email protected]> Co-authored-by: Shinnosuke Hirakawa <[email protected]>
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
Jun 18, 2024
autowarefoundation#572) feat(component_state_monitor): monitor traffic light recognition output (autowarefoundation#720) Signed-off-by: Tomohito Ando <[email protected]>
yuki-takagi-66
referenced
this pull request
in tier4/autoware_launch
Jul 8, 2024
* feat: tune condition of between cruise and stop (#565) Tune condition of between cruise and stop * fix(traffic_light): stop if the traffic light signal timed out (#727) (#571) Signed-off-by: Fumiya Watanabe <[email protected]> Co-authored-by: Fumiya Watanabe <[email protected]> * feat(component_state_monitor): monitor traffic light recognition outp… (#572) feat(component_state_monitor): monitor traffic light recognition output (#720) Signed-off-by: Tomohito Ando <[email protected]> * update ground segmentation Signed-off-by: yoshiri <[email protected]> * update comparemap parameter Signed-off-by: yoshiri <[email protected]> * update clustering parameters Signed-off-by: yoshiri <[email protected]> * fix tracking iou threshold parameters Signed-off-by: yoshiri <[email protected]> * feat: set smaller threshold for euclidean clustering Signed-off-by: yoshiri <[email protected]> * chore: fit parameter for v3.0.0 Signed-off-by: yoshiri <[email protected]> --------- Signed-off-by: Fumiya Watanabe <[email protected]> Signed-off-by: Tomohito Ando <[email protected]> Signed-off-by: yoshiri <[email protected]> Co-authored-by: Shohei Sakai <[email protected]> Co-authored-by: Tomohito ANDO <[email protected]> Co-authored-by: Fumiya Watanabe <[email protected]> Co-authored-by: Shinnosuke Hirakawa <[email protected]>
yuki-takagi-66
referenced
this pull request
in tier4/autoware_launch
Aug 1, 2024
chore: sync beta upstream
mitukou1109
pushed a commit
to mitukou1109/autoware_launch
that referenced
this pull request
Dec 23, 2024
…arefoundation#720) Signed-off-by: yuki-takagi-66 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I propose adding a topic monitor for the output of the traffic light recognition system.
Please see the autowarefoundation/autoware.universe#5778 for more details.
Tests performed
See autowarefoundation/autoware.universe#5778
Effects on system behavior
If traffic signal messages are not received or its topic rate is decreased, the vehicle will enter the emergency state.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.