Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(radar_object_clustering): move radar object clustering params to autoware_launch #672

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Nov 1, 2023

Description

Move radar_object_clustering parameter to autoware_launch so that each pilot.auto project can change these parameters.

Related links

Show universe pr here later.

Tests performed

Tested with lsim and checked with ros2 param.

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@YoshiRi YoshiRi requested a review from scepter914 November 1, 2023 04:37
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshiRi YoshiRi merged commit 6679b5d into autowarefoundation:main Nov 16, 2023
8 of 9 checks passed
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
mitukou1109 pushed a commit to mitukou1109/autoware_launch that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants