-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pid_longitudinal_controller): adjust slope compensation parameters #585
Merged
brkay54
merged 1 commit into
autowarefoundation:main
from
brkay54:pid/remove-slope-option
Feb 9, 2024
Merged
feat(pid_longitudinal_controller): adjust slope compensation parameters #585
brkay54
merged 1 commit into
autowarefoundation:main
from
brkay54:pid/remove-slope-option
Feb 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
TomohitoAndo
pushed a commit
to TomohitoAndo/autoware_launch.awf
that referenced
this pull request
Oct 20, 2023
chore: sync awf-latest
brkay54
force-pushed
the
pid/remove-slope-option
branch
from
November 10, 2023 12:44
122ec66
to
fdcd584
Compare
brkay54
changed the title
feat(pid_longitudinal_controller): remove use_trajectory_for_pitch_calculation option
feat(pid_longitudinal_controller): adjust slope compensation parameters
Nov 10, 2023
7 tasks
soblin
pushed a commit
to soblin/autoware_launch
that referenced
this pull request
Nov 18, 2023
…rger_param fix(object_merger): separate GIoU (autowarefoundation#497)
brkay54
force-pushed
the
pid/remove-slope-option
branch
from
December 5, 2023 12:38
fdcd584
to
84bfb8f
Compare
brkay54
force-pushed
the
pid/remove-slope-option
branch
from
December 21, 2023 07:03
84bfb8f
to
81fe47e
Compare
brkay54
force-pushed
the
pid/remove-slope-option
branch
2 times, most recently
from
February 1, 2024 10:26
8d2b58e
to
a5b5967
Compare
Signed-off-by: Berkay Karaman <[email protected]>
brkay54
force-pushed
the
pid/remove-slope-option
branch
from
February 5, 2024 22:29
a5b5967
to
7f148c7
Compare
TakaHoribe
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Merge with autowarefoundation/autoware.universe#4712
This was referenced Feb 9, 2024
yuki-takagi-66
referenced
this pull request
in tier4/autoware_launch
Jul 8, 2024
* chore: change max_z of cropbox filter to vehicle_height Signed-off-by: badai-nguyen <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: badai-nguyen <[email protected]> Co-authored-by: badai-nguyen <[email protected]>
Kazunori-Nakajima
pushed a commit
to Kazunori-Nakajima/autoware_launch
that referenced
this pull request
Oct 17, 2024
chore: sync awf-latest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because the slope compensation algorithm changes, we need to adjust parameters.
autowarefoundation/autoware.universe#4712
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.