Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_cruise_planner): add parameters for a new feature #581

Conversation

yuki-takagi-66
Copy link
Contributor

Description

We add two parameters corresponding to the new feature autowarefoundation/autoware.universe#5036
This PR should be merged BEFORE the corresponding PR in the autoware.univverse is merged.

Tests performed

Tests are performed in Psim, and the all of new parameters work well.

Effects on system behavior

obstacle_cruise_planner will not be launched with the default settings, so there is no effects when this PR is merged.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

yuki-takagi-66 and others added 7 commits September 20, 2023 11:30
cruise polygon expansion is still true

Signed-off-by: Yuki Takagi <[email protected]>
use stop planner as cruise planner type (conventional setting)
polygon expansion in obstacle_cruise_planner is true

Signed-off-by: Yuki Takagi <[email protected]>
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review September 21, 2023 07:21
Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuki-takagi-66 yuki-takagi-66 merged commit f4ed3ba into autowarefoundation:main Sep 25, 2023
8 of 9 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the feat/obstacle-cruise/cosider-current-ego-pose_awf-main-base branch September 25, 2023 07:23
TomohitoAndo pushed a commit to TomohitoAndo/autoware_launch.awf that referenced this pull request Oct 20, 2023
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
…warefoundation#581) (autowarefoundation#661)

* feat: add parameters for the feature "cosider-current-ego-pose"



* set the params to be merged.
use stop planner as cruise planner type (conventional setting)
polygon expansion in obstacle_cruise_planner is true



---------

Signed-off-by: Yuki Takagi <[email protected]>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Feb 6, 2024
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 21, 2024
…ndation#581)

* hazard_lights_selector

Signed-off-by: Mamoru Sobue <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Mamoru Sobue <[email protected]>
Co-authored-by: soblin <[email protected]>
yuki-takagi-66 referenced this pull request in tier4/autoware_launch Jul 8, 2024
* hazard_lights_selector

Signed-off-by: Mamoru Sobue <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Mamoru Sobue <[email protected]>
Co-authored-by: soblin <[email protected]>
Kazunori-Nakajima pushed a commit to Kazunori-Nakajima/autoware_launch that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants