Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pid_longitudinal_controller): change default slope compesation source to trajectory_adaptive #1276

Merged
merged 1 commit into from
Dec 16, 2024
Merged

feat(pid_longitudinal_controller): change default slope compesation source to trajectory_adaptive #1276

merged 1 commit into from
Dec 16, 2024

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Dec 16, 2024 •
edited
Loading

Description

universe PR: autowarefoundation/autoware.universe#9656

How was this PR tested?

psim and tier4 scenario test

Notes for reviewers

None.

Effects on system behavior

None.

@github-actions github-actions bot added component:localization Vehicle's position determination in its environment. (auto-assigned) component:system System design and integration. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Dec 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 16, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:ui User interface, user experience, graphical user interfaces. (auto-assigned) labels Dec 16, 2024
@yuki-takagi-66 yuki-takagi-66 mentioned this pull request Dec 16, 2024
Merged
@yuki-takagi-66 yuki-takagi-66 changed the title feat(pid_longitudinal_controller): update trajectory_adaptive; add debug_values, adopt rate limit fillter feat(pid_longitudinal_controller): use trajecory_adaptive as default slope compesation argolithm Dec 16, 2024
@yuki-takagi-66
po
7cf50f3 
Signed-off-by: yuki-takagi-66 <[email protected]>
@yuki-takagi-66 yuki-takagi-66 force-pushed the takagi/slope/use-trajectory_adaptive branch from 4170be7 to 7cf50f3 Compare December 16, 2024 08:37
@github-actions github-actions bot removed component:localization Vehicle's position determination in its environment. (auto-assigned) component:system System design and integration. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:ui User interface, user experience, graphical user interfaces. (auto-assigned) labels Dec 16, 2024
@yuki-takagi-66 yuki-takagi-66 changed the title feat(pid_longitudinal_controller): use trajecory_adaptive as default slope compesation argolithm feat(pid_longitudinal_controller): change default slope compesation source to trajectory_adaptive Dec 16, 2024
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review December 16, 2024 08:43
@yuki-takagi-66 yuki-takagi-66 merged commit 45ad76b into autowarefoundation:main Dec 16, 2024
16 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the takagi/slope/use-trajectory_adaptive branch December 16, 2024 10:33
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takayuki5168 takayuki5168 takayuki5168 approved these changes

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@danielsanchezaran danielsanchezaran Awaiting requested review from danielsanchezaran

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4

@go-sakayori go-sakayori Awaiting requested review from go-sakayori

@kosuke55 kosuke55 Awaiting requested review from kosuke55

@mkquda mkquda Awaiting requested review from mkquda

@maxime-clem maxime-clem Awaiting requested review from maxime-clem

@soblin soblin Awaiting requested review from soblin

@yhisaki yhisaki Awaiting requested review from yhisaki

Assignees

@takayuki5168 takayuki5168

Labels
run:build-and-test-differential
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuki-takagi-66 @takayuki5168