Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(system_diagnostic_monitor, dummy_diag_publisher, diagnostic_graph_aggregator): combine diag list directories #1249

Closed
wants to merge 327 commits into from
Closed

refactor(system_diagnostic_monitor, dummy_diag_publisher, diagnostic_graph_aggregator): combine diag list directories #1249

wants to merge 327 commits into from

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Nov 25, 2024 •
edited
Loading

Description

Currently, by the historical reason, diagnostic graph settings are located in the following three directories

  1. diagnostc_graph_aggregator: link to system_diagnostic_monitor
  2. system_diagnostic_monitor: path settings to be checked
  3. dummy_diag_publisher: path settings to be ignore

This PR merge these directories to one directory.

Related links

part of #1221

Tests performed

psim and tier4 scenario tests

Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

tier4-autoware-public-bot bot and others added 30 commits April 3, 2024 02:53
@tier4-autoware-public-bot
Merge pull request #366 from tier4/sync-awf-latest
a1c7059 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #369 from tier4/sync-awf-latest
38b1ec5 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #370 from tier4/sync-awf-latest
28b7d00 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #372 from tier4/sync-awf-latest
89f74e0 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #374 from tier4/sync-awf-latest
0d57ad5 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #375 from tier4/sync-awf-latest
e035a22 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #376 from tier4/sync-awf-latest
5f1819f 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #377 from tier4/sync-awf-latest
b16eec9 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #378 from tier4/sync-awf-latest
2d034f3 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #380 from tier4/sync-awf-latest
24dfbdb 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #381 from tier4/sync-awf-latest
c9663f0 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #384 from tier4/sync-awf-latest
06e4707 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #385 from tier4/sync-awf-latest
c118fab 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #386 from tier4/sync-awf-latest
ba38036 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #387 from tier4/sync-awf-latest
4b95c59 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #389 from tier4/sync-awf-latest
cfbd1e1 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #390 from tier4/sync-awf-latest
838a7dc 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #392 from tier4/sync-awf-latest
efef020 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #393 from tier4/sync-awf-latest
567dba0 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #394 from tier4/sync-awf-latest
03435f1 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #395 from tier4/sync-awf-latest
9f8e435 
chore: sync awf-latest
@badai-nguyen
Merge branch 'autowarefoundation:main' into awf-latest
031c3d0
@tier4-autoware-public-bot
Merge pull request #396 from tier4/sync-awf-latest
240c5f9 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #397 from tier4/sync-awf-latest
6af5c31 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #398 from tier4/sync-awf-latest
1abb875 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #399 from tier4/sync-awf-latest
dd6e2b0 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #401 from tier4/sync-awf-latest
d604455 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #402 from tier4/sync-awf-latest
196c69e 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #403 from tier4/sync-awf-latest
4f705dd 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #404 from tier4/sync-awf-latest
29215a0 
chore: sync awf-latest
tier4-autoware-public-bot bot and others added 12 commits November 19, 2024 02:18
@tier4-autoware-public-bot
Merge pull request #674 from tier4/sync-awf-latest
8b51fc9 
chore: sync awf-latest
@takayuki5168
feat: enable MRM summary
28767b4 
Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168
Merge pull request #675 from tier4/feat/enable-mrm-summary
6a0b563 
feat: enable MRM summary
@takayuki5168
Merge branch 'awf-latest' into sync-awf-latest
3d20c99
@takayuki5168
Merge pull request #676 from tier4/sync-awf-latest
73a9c27 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #678 from tier4/sync-awf-latest
268975a 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #679 from tier4/sync-awf-latest
ed22255 
chore: sync awf-latest
@tier4-autoware-public-bot
Merge pull request #680 from tier4/sync-awf-latest
90770e1 
chore: sync awf-latest
@yuki-takagi-66
merge to new folder
2bb31d0 
Signed-off-by: Yuki Takagi <[email protected]>
@yuki-takagi-66
delete old dir
6f1747e 
Signed-off-by: Yuki Takagi <[email protected]>
@yuki-takagi-66
ref new dir
5c8f2e8 
Signed-off-by: Yuki Takagi <[email protected]>
@yuki-takagi-66
delete old dir
22f20df 
Signed-off-by: Yuki Takagi <[email protected]>
@github-actions github-actions bot added component:localization Vehicle's position determination in its environment. (auto-assigned) component:system System design and integration. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:ui User interface, user experience, graphical user interfaces. (auto-assigned) labels Nov 25, 2024
@yuki-takagi-66 yuki-takagi-66 added run:build-and-test-differential and removed component:localization Vehicle's position determination in its environment. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:ui User interface, user experience, graphical user interfaces. (auto-assigned) labels Nov 25, 2024
@yuki-takagi-66 yuki-takagi-66 deleted the takagi/diag/refactor-directories branch November 26, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ito-san ito-san Awaiting requested review from ito-san ito-san will be requested when the pull request is marked ready for review ito-san is a code owner

@isamu-takagi isamu-takagi Awaiting requested review from isamu-takagi isamu-takagi will be requested when the pull request is marked ready for review isamu-takagi is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk will be requested when the pull request is marked ready for review shmpwk is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 will be requested when the pull request is marked ready for review tkimura4 is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 will be requested when the pull request is marked ready for review takayuki5168 is a code owner

@rej55 rej55 Awaiting requested review from rej55 rej55 will be requested when the pull request is marked ready for review rej55 is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota will be requested when the pull request is marked ready for review satoshi-ota is a code owner

@yukkysaito yukkysaito Awaiting requested review from yukkysaito yukkysaito will be requested when the pull request is marked ready for review yukkysaito is a code owner

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r mitsudome-r will be requested when the pull request is marked ready for review mitsudome-r is a code owner

Assignees
No one assigned
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@yuki-takagi-66 @badai-nguyen @satoshi-ota @takayuki5168 @danielsanchezaran @TakaHoribe @kosuke55 @kyoichi-sugahara @go-sakayori @xtk8532704