Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge tier4/autoware_launch v0.38.0 changes to awf/autoware_launch main branch excepts .github changes #1228

Closed
wants to merge 1,426 commits into from

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Nov 14, 2024

Description

This PR contains the differences from the v0.38.0 tag of tier4/autoware_launch to the main branch of awf/autoware_launch, excluding changes to .github directory.

main...tier4:autoware_launch:v0.38.0

This PR is the second step in implementing changes based on https://github.com/orgs/autowarefoundation/discussions/5292. Next, I plan to update the versions in package.xml on the main branch of awf/autoware_launch.

Ref. autowarefoundation/autoware.universe#9261

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

tier4-autoware-public-bot bot and others added 30 commits April 19, 2024 08:53
…in-sync

chore: sync beta branch beta/v0.27.0 with tier4/main
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <[email protected]>
chore: sync tier4/autoware_launch:awf-latest
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk
Copy link
Member Author

youtalk commented Nov 14, 2024

The forked tier4/autoware_launch repository likely contains specific adjustments tailored for TIER IV products. If you have any opinions, such as that this parameter should not be reflected upstream, please let me know.

@xmfcx
Copy link
Contributor

xmfcx commented Nov 14, 2024

Is it possible for us to get a reason for why each parameters are being changed?

For example, the max velocity was limited to 15 km/h for this reason:

It was done for safety reasons while transitioning from obstacle_stop_planner to obstacle_cruise_planner. And the AEB doesn't work reliably for velocities higher than 15km/h.

This goes for all the changes, the PR description and title should contain the reasons these were changed. Not just "merging from tier4 fork for version control".

@xmfcx
Copy link
Contributor

xmfcx commented Nov 26, 2024

@youtalk -san, since

@youtalk
Copy link
Member Author

youtalk commented Nov 27, 2024

@xmfcx I want to minimize the differences with the tier4 forked repository, but since there might be some discussion, I’ll close this for now and reconsider.

@youtalk youtalk closed this Nov 27, 2024
@youtalk youtalk deleted the 0.38.0-patch branch November 27, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential
Projects
None yet
Development

Successfully merging this pull request may close these issues.