-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autonomous_emergency_braking): change params to cater to urban scenario #1197
Merged
danielsanchezaran
merged 1 commit into
autowarefoundation:main
from
tier4:feat/update-aeb-params-for-real-life-scenarios
Oct 24, 2024
Merged
feat(autonomous_emergency_braking): change params to cater to urban scenario #1197
danielsanchezaran
merged 1 commit into
autowarefoundation:main
from
tier4:feat/update-aeb-params-for-real-life-scenarios
Oct 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Sanchez <[email protected]>
danielsanchezaran
requested review from
takayuki5168,
rej55,
satoshi-ota,
shmpwk,
kyoichi-sugahara,
zulfaqar-azmi-t4,
go-sakayori,
kosuke55,
mkquda,
maxime-clem,
soblin and
yhisaki
as code owners
October 23, 2024 07:24
kyoichi-sugahara
approved these changes
Oct 23, 2024
danielsanchezaran
deleted the
feat/update-aeb-params-for-real-life-scenarios
branch
October 24, 2024 01:06
danielsanchezaran
added a commit
to tier4/autoware_launch
that referenced
this pull request
Oct 24, 2024
…cenario (autowarefoundation#1197) update scenarios Signed-off-by: Daniel Sanchez <[email protected]>
4 tasks
technolojin
pushed a commit
to technolojin/autoware_launch
that referenced
this pull request
Dec 17, 2024
…utowarefoundation#838) * feat(autonomous_emergency_braking): add params to enable or disable PC and predicted objects (autowarefoundation#1031) * add params to enable or disable PC and predicted objects Signed-off-by: Daniel Sanchez <[email protected]> * set predicted object usage to false Signed-off-by: Daniel Sanchez <[email protected]> --------- Signed-off-by: Daniel Sanchez <[email protected]> * feat(autonomous_emergency_braking): add and tune params (autowarefoundation#1037) * add and tune params Signed-off-by: Daniel Sanchez <[email protected]> * set back voxel grid z Signed-off-by: Daniel Sanchez <[email protected]> * fix grid to what it is in OSS launch Signed-off-by: Daniel Sanchez <[email protected]> --------- Signed-off-by: Daniel Sanchez <[email protected]> * feat(autonomous_emergency_braking): add param for oublishing debug markers (autowarefoundation#1063) add param for oublishing debug markers Signed-off-by: Daniel Sanchez <[email protected]> * feat(autonomous_emergency_braking): enable AEB stop in vehicle_cmd_gate and diag_graph_agg (autowarefoundation#1099) * enable emergency handling for AEB stop Signed-off-by: Daniel Sanchez <[email protected]> * update AEB params to work better at 30 kmph Signed-off-by: Daniel Sanchez <[email protected]> --------- Signed-off-by: Daniel Sanchez <[email protected]> * feat(autonomous_emergency_braking): add info marker to aeb and state check override (autowarefoundation#1103) * add info marker and override for state Signed-off-by: Daniel Sanchez <[email protected]> * make stop wall viz default Signed-off-by: Daniel Sanchez <[email protected]> --------- Signed-off-by: Daniel Sanchez <[email protected]> * feat(autonomous_emergency_braking): initiate speed_calculation_expansion_margin parameter (autowarefoundation#1168) initiate speed_calculation_expansion_margin parameter Signed-off-by: ismetatabay <[email protected]> * feat(autonomous_emergency_braking): set max imu path length (autowarefoundation#1183) * set param for max imu path distance Signed-off-by: Daniel Sanchez <[email protected]> * change param Signed-off-by: Daniel Sanchez <[email protected]> --------- Signed-off-by: Daniel Sanchez <[email protected]> * feat(autonomous_emergency_braking): change params to cater to urban scenario (autowarefoundation#1197) update scenarios Signed-off-by: Daniel Sanchez <[email protected]> * enable aeb by default Signed-off-by: Daniel Sanchez <[email protected]> * refactor(rviz): add VirtualWall display for Autonomous Emergency Braking (autowarefoundation#1187) feat(rviz): add VirtualWall display for Autonomous Emergency Braking Signed-off-by: kyoichi-sugahara <[email protected]> * disable AEB stop wall viz Signed-off-by: Daniel Sanchez <[email protected]> * revert mrm emergency stop param changes Signed-off-by: Daniel Sanchez <[email protected]> --------- Signed-off-by: Daniel Sanchez <[email protected]> Signed-off-by: ismetatabay <[email protected]> Signed-off-by: kyoichi-sugahara <[email protected]> Co-authored-by: Ismet Atabay <[email protected]> Co-authored-by: Kyoichi Sugahara <[email protected]> Co-authored-by: Tomohito ANDO <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These parameters changes are based on recent real-life tests on Odaiba. These tests were aimed at reducing unwanted AEB activation caused by vegetation close to the ego path and the AEB's IMU path activating an emergency stop when the ego turns at high speeds.
The voxel grid changes are aimed at maintaining AEB performance while being able to detect thin and long objects.
With these parameters, no unwanted activation happened for our tests. These parameters are aimed at a regular sized vehicle implementation in urban environments and should be tuned based on the user's needs. These parameters might be considered to be a bit on the conservative side (harder to activate AEB stop).
Tests performed
Real life tests at Odaiba.
Degradation check: https://evaluation.tier4.jp/evaluation/reports/dbbc4faf-6813-5720-a34f-29aa635561f0?project_id=prd_jt (no degradation?)
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.