Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(processing_time_checker): add five module. #1192

Conversation

Kazunori-Nakajima
Copy link
Contributor

@Kazunori-Nakajima Kazunori-Nakajima commented Oct 17, 2024

Description

Purpose

To be able to check the values of the modules added in the relationship PR in the scenario.

Merit

To be able to measure module processing time periodically by scenario.And leads to the following
-> Prevention of cycle failures.
-> Suggestion to improve module processing speed.

Updated

Added 5 module paths to processing_time_checker.yml to read processing_time_pub from the scenario.

Related links

discussion slack link
(I have not discussed this on github.)

Tests performed

From the red circle in the image, you can see that the value of the module you have just added is retrieved when the scenario is turned on locally. (Sorry for the small text 🙇‍♂)

image

Notes for reviewers

Changes on the universe side (already merged)

Interface changes

This PR

  • processing_time_checker

Related PR (universe)

  • /control/control_validator/debug/processing_time_ms
  • /control/vehicle_cmd_gate/debug/processing_time_ms
  • /planning/scenario_planning/lane_driving/motion_planning/surround_obstacle_checker/debug/processing_time_ms
  • /planning/scenario_planning/parking/costmap_generator/debug/processing_time_ms
  • /planning/scenario_planning/scenario_selector/debug/processing_time_ms

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55
Copy link
Contributor

looks good to me

@ito-san @isamu-takagi
could you please approve as a code owner?

@ito-san ito-san added the enhancement New feature or request label Oct 18, 2024
@ito-san
Copy link
Contributor

ito-san commented Oct 18, 2024

@Kazunori-Nakajima @kosuke55
Please choose either a "Standard Change" or a "Small Change" and fill out the pull request according to the corresponding template, and what is the purpose and benefit of implementing this?

@Kazunori-Nakajima
Copy link
Contributor Author

@ito-san
The purpose is to be able to read the module processing time from the scenario.
We are looking to improve cycle drop and processing time by adding a condition by processing time to the scenario.

I selected “Standard Change” and filled it out again according to the template.
Please review it again🙇‍♂🙇‍♂🙇‍♂.

@kosuke55
Copy link
Contributor

@ito-san kindly ping 🙇 🙇

Copy link
Contributor

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ito-san ito-san merged commit 01398f3 into autowarefoundation:main Oct 24, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants