Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rviz): add VirtualWall display for Autonomous Emergency Braking #1187

Merged

Conversation

kyoichi-sugahara
Copy link
Contributor

Description

necessary change for the PR

Tests performed

run psim and result is explained in the PR

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:ui User interface, user experience, graphical user interfaces. (auto-assigned) label Oct 10, 2024
@kyoichi-sugahara kyoichi-sugahara changed the title feat(rviz): add VirtualWall display for Autonomous Emergency Braking refactor(rviz): add VirtualWall display for Autonomous Emergency Braking Oct 10, 2024
Copy link
Contributor

@danielsanchezaran danielsanchezaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyoichi-sugahara kyoichi-sugahara merged commit b7d1568 into autowarefoundation:main Oct 11, 2024
14 of 15 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the refactor/publish_virtual_wall branch October 11, 2024 07:36
danielsanchezaran pushed a commit to tier4/autoware_launch that referenced this pull request Nov 21, 2024
…ing (autowarefoundation#1187)

feat(rviz): add VirtualWall display for Autonomous Emergency Braking

Signed-off-by: kyoichi-sugahara <[email protected]>
technolojin pushed a commit to technolojin/autoware_launch that referenced this pull request Dec 17, 2024
…utowarefoundation#838)

* feat(autonomous_emergency_braking): add params to enable or disable PC and predicted objects (autowarefoundation#1031)

* add params to enable or disable PC and predicted objects

Signed-off-by: Daniel Sanchez <[email protected]>

* set predicted object usage to false

Signed-off-by: Daniel Sanchez <[email protected]>

---------

Signed-off-by: Daniel Sanchez <[email protected]>

* feat(autonomous_emergency_braking): add and tune params (autowarefoundation#1037)

* add and tune params

Signed-off-by: Daniel Sanchez <[email protected]>

* set back voxel grid z

Signed-off-by: Daniel Sanchez <[email protected]>

* fix grid to what it is in OSS launch

Signed-off-by: Daniel Sanchez <[email protected]>

---------

Signed-off-by: Daniel Sanchez <[email protected]>

* feat(autonomous_emergency_braking): add param for oublishing debug markers (autowarefoundation#1063)

add param for oublishing debug markers

Signed-off-by: Daniel Sanchez <[email protected]>

* feat(autonomous_emergency_braking): enable AEB stop in vehicle_cmd_gate and diag_graph_agg (autowarefoundation#1099)

* enable emergency handling for AEB stop

Signed-off-by: Daniel Sanchez <[email protected]>

* update AEB params to work better at 30 kmph

Signed-off-by: Daniel Sanchez <[email protected]>

---------

Signed-off-by: Daniel Sanchez <[email protected]>

* feat(autonomous_emergency_braking): add info marker to aeb and state check override (autowarefoundation#1103)

* add info marker and override for state

Signed-off-by: Daniel Sanchez <[email protected]>

* make stop wall viz default

Signed-off-by: Daniel Sanchez <[email protected]>

---------

Signed-off-by: Daniel Sanchez <[email protected]>

* feat(autonomous_emergency_braking): initiate speed_calculation_expansion_margin parameter (autowarefoundation#1168)

initiate speed_calculation_expansion_margin parameter

Signed-off-by: ismetatabay <[email protected]>

* feat(autonomous_emergency_braking): set max imu path length (autowarefoundation#1183)

* set param for max imu path distance

Signed-off-by: Daniel Sanchez <[email protected]>

* change param

Signed-off-by: Daniel Sanchez <[email protected]>

---------

Signed-off-by: Daniel Sanchez <[email protected]>

* feat(autonomous_emergency_braking): change params to cater to urban scenario (autowarefoundation#1197)

update scenarios

Signed-off-by: Daniel Sanchez <[email protected]>

* enable aeb by default

Signed-off-by: Daniel Sanchez <[email protected]>

* refactor(rviz): add VirtualWall display for Autonomous Emergency Braking (autowarefoundation#1187)

feat(rviz): add VirtualWall display for Autonomous Emergency Braking

Signed-off-by: kyoichi-sugahara <[email protected]>

* disable AEB stop wall viz

Signed-off-by: Daniel Sanchez <[email protected]>

* revert mrm emergency stop param changes

Signed-off-by: Daniel Sanchez <[email protected]>

---------

Signed-off-by: Daniel Sanchez <[email protected]>
Signed-off-by: ismetatabay <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Co-authored-by: Ismet Atabay <[email protected]>
Co-authored-by: Kyoichi Sugahara <[email protected]>
Co-authored-by: Tomohito ANDO <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ui User interface, user experience, graphical user interfaces. (auto-assigned) run:build-and-test-differential
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants