fix(perception): adopt awsim (tlr) camera topic #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:simulation
MasatoSaeki
requested review from
miursh,
YoshiRi,
kminoda,
yukkysaito,
mitsudome-r and
xmfcx
as code owners
YoshiRi
reviewed
Sep 20, 2024
Signed-off-by: MasatoSaeki <[email protected]>
xmfcx
force-pushed
the
fix/tlr_on_awsim
branch
from
562d3f2 to
21c348c
Compare
|
I've rebased this to the latest main. Now testing with AWSIM Labs. https://github.com/autowarefoundation/AWSIM-Labs/releases |
|
Works with the latest AWSIM Labs 👍 |
xmfcx
approved these changes
Sep 20, 2024
|
@MasatoSaeki -san please next time test with AWSIM Labs. AWSIM Labs is much more advanced, faster, lighter and with more features than the original AWSIM. And it works with the main branch of the Autoware. |
|
@xmfcx |
MasatoSaeki
added a commit
to tier4/autoware_launch
that referenced
this pull request
Sep 20, 2024
) Signed-off-by: MasatoSaeki <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enable to adopt awsim camera topic.
link
Tests performed
I have checked on AWSIM
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.