-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change visualization of localization results from PoseHistory to PoseWithCovarianceHistory #1164
Merged
SakodaShintaro
merged 4 commits into
autowarefoundation:main
from
SaltUhey:tier4_localization_rviz_plugin
Sep 17, 2024
Merged
feat: change visualization of localization results from PoseHistory to PoseWithCovarianceHistory #1164
SakodaShintaro
merged 4 commits into
autowarefoundation:main
from
SaltUhey:tier4_localization_rviz_plugin
Sep 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yuhei <[email protected]>
github-actions
bot
added
the
component:ui
User interface, user experience, graphical user interfaces. (auto-assigned)
label
Sep 12, 2024
Signed-off-by: yuhei <[email protected]>
…' into tier4_localization_rviz_plugin
YamatoAndo
requested review from
RyuYamamoto,
anhnv3991,
YamatoAndo,
SakodaShintaro,
Motsu-san and
TaikiYamada4
September 12, 2024 09:05
SakodaShintaro
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot.
I have verified that logging_simulator works well and the default visualization in Rviz is the same as before.
I also enabled the covariance visualization and checked it.
LGTM
This slowed down rviz2 from 31 stable fps to 5 fps. |
4 tasks
xmfcx
added a commit
that referenced
this pull request
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:ui
User interface, user experience, graphical user interfaces. (auto-assigned)
run:build-and-test-differential
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change rviz config for visualization of pose with covariance history.
Related links
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.