Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crosswalk)!: update stop position caluculation #1162

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Sep 11, 2024

Description

This PR changes the parameter set to follow the universe side: autowarefoundation/autoware.universe#8853

Related links

universe PR: autowarefoundation/autoware.universe#8853

Tests performed

psim and tier4 internal tests

Notes for reviewers

Interface changes

ROS Topic Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:system System design and integration. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) labels Sep 11, 2024
@yuki-takagi-66 yuki-takagi-66 changed the title Takagi/crosswalk/add new stop position feat(crosswalk)!: update stop position caluculation Sep 11, 2024
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review September 13, 2024 08:34
@takayuki5168 takayuki5168 marked this pull request as draft September 13, 2024 09:15
@yuki-takagi-66 yuki-takagi-66 force-pushed the takagi/crosswalk/add-new-stop-position branch from cc43708 to 63a8553 Compare September 13, 2024 09:39
@github-actions github-actions bot removed component:system System design and integration. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) labels Sep 13, 2024
Signed-off-by: Yuki Takagi <[email protected]>
@yuki-takagi-66 yuki-takagi-66 force-pushed the takagi/crosswalk/add-new-stop-position branch from 6272b6c to 5101a27 Compare September 13, 2024 10:11
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review September 13, 2024 10:27
@yuki-takagi-66 yuki-takagi-66 merged commit 8fa0953 into autowarefoundation:main Sep 13, 2024
13 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the takagi/crosswalk/add-new-stop-position branch September 13, 2024 11:01
yuki-takagi-66 added a commit that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants