Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lidar_centerpoint): fix centerpoint_sigma parameters #1122

Closed
wants to merge 3 commits into from

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Aug 19, 2024

Description

#915 missed centerpoint_sigma parameter fixes.
So I fixed it. Though centerpoint_sigma model is not ready to open, I want to enable this model potentially.

Tests performed

Tested with Lsim.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@YoshiRi YoshiRi requested review from miursh and kminoda as code owners August 19, 2024 07:18
@YoshiRi YoshiRi requested a review from badai-nguyen August 19, 2024 07:19
Copy link
Contributor

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YoshiRi Thank you for your fixing.
LGTM

BTW, I drafted the same PR for autoware_launch (#1086) that I think we need merge together.

@YoshiRi
Copy link
Contributor Author

YoshiRi commented Aug 20, 2024

PR is already solved. Close this

@YoshiRi YoshiRi closed this Aug 20, 2024
@YoshiRi YoshiRi deleted the feat/fix_centerpoint_sigma branch August 20, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants