Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map_based_prediction): use different time horizon #1005

Conversation

soblin
Copy link
Contributor

@soblin soblin commented May 29, 2024

Description

autowarefoundation/autoware.universe#7157

Related links

autowarefoundation/autoware.universe#7157

Tests performed

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@soblin soblin requested review from miursh, YoshiRi and kminoda as code owners May 29, 2024 06:16
@github-actions github-actions bot added the component:map Map creation, storage, and loading. (auto-assigned) label May 29, 2024
@soblin soblin changed the title feat(map_based_prediction): use different time horizon do not merge this May 29, 2024
@soblin soblin changed the title do not merge this feat(map_based_prediction): use different time horizon May 30, 2024
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soblin soblin merged commit f7e6dd7 into autowarefoundation:main May 30, 2024
22 of 23 checks passed
@soblin soblin deleted the feat/map_based_prediction/different-horizon branch May 30, 2024 06:58
Ericpotato pushed a commit to tier4/autoware_launch that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:map Map creation, storage, and loading. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants