Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_launch): add diagnostic graph config for awsim #1000

Merged

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented May 27, 2024

Description

Since diagnostic_graph_aggregator_graph_path depends on the simulator, I made it possible to specify the path from each launch file. This will replace system_error_monitor_param_path. See this discussion for details.

This PR be merged with autowarefoundation/autoware.universe#7133 at the same time.

Tests performed

Diagnostics determine the transition to autonomous mode. So I confirmed whether it was possible to transition to autonomous mode in each simulation. (Logging simulation is not applicable as it does not require a mode change.)

  • Run planning simulation (check if it can drive in autonomous mode)
  • Run logging simulation (check if the rosbag is visualized with rviz)
  • Run E2E simulation (check if it can drive in autonomous mode)

Effects on system behavior

The new settings are made to be compatible with system_error_monitor's.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:system System design and integration. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels May 27, 2024
@isamu-takagi isamu-takagi marked this pull request as ready for review May 27, 2024 08:34
@isamu-takagi isamu-takagi self-assigned this May 27, 2024
Copy link
Contributor

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xmfcx
Copy link
Contributor

xmfcx commented May 27, 2024

How was this tested?

How can we make sure it's working?

@isamu-takagi
Copy link
Contributor Author

isamu-takagi commented May 27, 2024

@xmfcx Update the test performed section. You can check if it can drive in autonomous mode for planning/E2E simulation.

@xmfcx xmfcx force-pushed the feat/diagnostic_graph_awsim branch from da445d0 to 4de6b01 Compare May 27, 2024 10:40
@xmfcx
Copy link
Contributor

xmfcx commented May 27, 2024

Rebased both this and autowarefoundation/autoware.universe#7133 to the latest main.

Edit: Tested with AWSIM-Labs too, it works the same.

image

Tested with the planning sim. Local is always disabled, is this normal behavior?

@isamu-takagi
Copy link
Contributor Author

Tested with the planning sim. Local is always disabled, is this normal behavior?

Yes, the local mode requires diagnostics from joy_controller. You can check details of diagnostics by following command.

ros2 run rqt_diagnostic_graph_monitor rqt_diagnostic_graph_monitor

Screenshot from 2024-05-27 19-59-26

@xmfcx
Copy link
Contributor

xmfcx commented May 27, 2024

image

@isamu-takagi -san said it's expected.

Running ros2 run rqt_diagnostic_graph_monitor rqt_diagnostic_graph_monitor from autoware_tools/tree/main/system/rqt_diagnostic_graph_monitor
It's expecting the joy_controller's diagnostics.

@xmfcx xmfcx merged commit b2f5bac into autowarefoundation:main May 27, 2024
10 of 11 checks passed
@isamu-takagi isamu-takagi deleted the feat/diagnostic_graph_awsim branch May 27, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:system System design and integration. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants