-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_launch): add diagnostic graph config for awsim #1000
feat(autoware_launch): add diagnostic graph config for awsim #1000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
How was this tested? How can we make sure it's working? |
@xmfcx Update the test performed section. You can check if it can drive in autonomous mode for planning/E2E simulation. |
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
da445d0
to
4de6b01
Compare
Rebased both this and autowarefoundation/autoware.universe#7133 to the latest main. Edit: Tested with AWSIM-Labs too, it works the same. Tested with the planning sim. Local is always disabled, is this normal behavior? |
@isamu-takagi -san said it's expected. Running |
Description
Since
diagnostic_graph_aggregator_graph_path
depends on the simulator, I made it possible to specify the path from each launch file. This will replacesystem_error_monitor_param_path
. See this discussion for details.This PR be merged with autowarefoundation/autoware.universe#7133 at the same time.
Tests performed
Diagnostics determine the transition to autonomous mode. So I confirmed whether it was possible to transition to autonomous mode in each simulation. (Logging simulation is not applicable as it does not require a mode change.)
Effects on system behavior
The new settings are made to be compatible with system_error_monitor's.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.