Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CHANGELOG): bump up version to 1.1.0 #19

Merged
merged 2 commits into from
Jul 1, 2024
Merged

feat(CHANGELOG): bump up version to 1.1.0 #19

merged 2 commits into from
Jul 1, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Jul 1, 2024

Description

bump up version to 1.1.0

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

youtalk added 2 commits July 1, 2024 14:03
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk self-assigned this Jul 1, 2024
@youtalk youtalk changed the title feat(CHANGELOG): bump up to 1.1.0 feat(CHANGELOG): bump up version to 1.1.0 Jul 1, 2024
Copy link
Contributor

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@youtalk please don't tag until this PR is merged (I'm talking about https://github.com/autowarefoundation/autoware_internal_msgs/releases/tag/1.1.0). Tags must point to commits that are in main to avoid potential issues with the buildfarm. Remove the tag and recreate when this PR is merged. Thanks.

@esteve
Copy link
Contributor

esteve commented Jul 1, 2024

In fact, the tag is already desynchronized with the commit history if this PR is merged because the tag is for a commit that's between 4537a08 and the current main. I've deleted the tag and we can recreate it when this PR is merged.

Copy link
Contributor

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving now that the tag is removed.

@esteve esteve enabled auto-merge (squash) July 1, 2024 09:39
@esteve
Copy link
Contributor

esteve commented Jul 1, 2024

@youtalk can you fix the DCO issue? Thanks.

@esteve esteve merged commit 4f5feff into main Jul 1, 2024
16 checks passed
@esteve esteve deleted the v1.1.0 branch July 1, 2024 09:43
@youtalk
Copy link
Member Author

youtalk commented Jul 1, 2024

@esteve Thank you for your support. I’ve got it.

@esteve
Copy link
Contributor

esteve commented Jul 1, 2024

@youtalk you're welcome 🙂 I've created a tag that points to the current commit in main, we should be able to publish a new package with bloom. Thanks for all the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants