Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_adapi_v1_msgs): add heartbeat #50

Merged
merged 5 commits into from
Apr 1, 2024

Conversation

isamu-takagi
Copy link
Collaborator

@isamu-takagi isamu-takagi commented Mar 27, 2024

Description

Add heartbeat message. This feature is requested by https://github.com/orgs/autowarefoundation/discussions/4561

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xmfcx
Copy link
Contributor

xmfcx commented Mar 27, 2024

If this is related, could you add it to the PR description?

@xmfcx
Copy link
Contributor

xmfcx commented Mar 27, 2024

https://github.com/autowarefoundation/autoware.core/blob/5ab56d1b560dfce85fb7d272e4ecb42022af32cc/common/autoware_control_center_msgs/msg/Heartbeat.msg#L7-L10

# Incremental sequence number used to verify the order of received heartbeats
# and identify potential message drops or delays.
# This number will wrap around once it reaches to its maximum value (65535)
uint16 sequence_number 0

Maybe we could also add a similar uint16 sequence_number 0 for the listener to detect if a heartbeat was missed.

Related PR:

@isamu-takagi isamu-takagi self-assigned this Mar 28, 2024
@isamu-takagi isamu-takagi enabled auto-merge (squash) April 1, 2024 05:37
@isamu-takagi isamu-takagi merged commit d996e40 into autowarefoundation:main Apr 1, 2024
9 checks passed
@isamu-takagi isamu-takagi deleted the feat/heartbeat branch April 3, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants