-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_adapi_v1_msgs): add heartbeat #50
Merged
isamu-takagi
merged 5 commits into
autowarefoundation:main
from
isamu-takagi:feat/heartbeat
Apr 1, 2024
Merged
feat(autoware_adapi_v1_msgs): add heartbeat #50
isamu-takagi
merged 5 commits into
autowarefoundation:main
from
isamu-takagi:feat/heartbeat
Apr 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takagi, Isamu <[email protected]>
If this is related, could you add it to the PR description? |
Maybe we could also add a similar Related PR: |
yukkysaito
reviewed
Mar 27, 2024
Signed-off-by: Takagi, Isamu <[email protected]>
xmfcx
reviewed
Mar 28, 2024
Co-authored-by: M. Fatih Cırıt <[email protected]>
xmfcx
approved these changes
Mar 28, 2024
yukkysaito
approved these changes
Mar 28, 2024
Signed-off-by: Takagi, Isamu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add heartbeat message. This feature is requested by https://github.com/orgs/autowarefoundation/discussions/4561
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.