Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update branch of scenario_simulator_v2 to master #5570

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rej55
Copy link

@rej55 rej55 commented Dec 16, 2024

Description

This PR updates the branch of scenario_simulator_v2 from RJD-736/autoware_msgs_support to master

Related link

tier4/scenario_simulator_v2@6d8ce96

How was this PR tested?

Checked following example works. Thanks to @sasakisasaki

https://tier4.github.io/scenario_simulator_v2-docs/user_guide/QuickStart/

Notes for reviewers

None.

Effects on system behavior

None.

@rej55 rej55 requested a review from mitsudome-r as a code owner December 16, 2024 11:26
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@rej55 rej55 requested a review from sasakisasaki December 16, 2024 11:26
Copy link
Collaborator

@sasakisasaki sasakisasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Reason for approval:

  • I tested by following steps:
    • Do git clone the autowarefoundation/autoware that of commit hash 5c01fb0991ea70c3ccb9112ba9739511bb38a491 (12nd Dec. 2024)
    • Applied following commands (Reference):
$ cd /path/to/autoware
$ mkdir src
$ vim simulator.repos

(Edit the version to `master` then save&exit)

$ vcs import src < autoware.repos
$ vcs import src < simulator.repos
$ source /opt/ros/humble/setup.bash
$ sudo apt update && sudo apt upgrade
$ rosdep update
$ rosdep install -y --from-paths src --ignore-src --rosdistro $ROS_DISTRO
$ colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release
$ source install/setup.bash
$ ros2 launch scenario_test_runner scenario_test_runner.launch.py architecture_type:=awf/universe/20240605 record:=false scenario:='$(find-pkg-share scenario_test_runner)/scenario/sample.yaml' sensor_model:=sample_sensor_kit vehicle_model:=sample_vehicle

(Three scenarios were launched. The final result of them was `passed`)

@mitsudome-r
Copy link
Member

I think it's okay to go with main, but since there are also version tags for scenario_simulator_v2, should we use them instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants