Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(.github): not push manifest if eithor amd64 or arm64 image is missing #5525

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix(.github): not push manifest if eithor amd64 or arm64 image is missing #5525

merged 1 commit into from
Dec 3, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Dec 3, 2024 •
edited
Loading

Description

When pushing the docker manifest for multi-architecture images, this PR does not push if either the amd64 image or the arm64 image is missing as following.

https://github.com/autowarefoundation/autoware/actions/runs/12130229119/job/33820159404#step:3:566

base_tag: universe-cuda
amd64_tag: 
arm64_tag: universe-cuda-arm64
No amd64 tag found for 'universe-cuda'.
amd64_image: 
arm64_image: ghcr.io/autowarefoundation/autoware:universe-cuda-arm64
Created manifest list ghcr.io/autowarefoundation/autoware:universe-cuda
sha256:eb74c92f9dc29ed2887924117bb97cfbd52653da50be6ccc003c7b85849f6aee

How was this PR tested?

Notes for reviewers

None.

Effects on system behavior

None.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@youtalk youtalk self-assigned this Dec 3, 2024
@youtalk youtalk added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check labels Dec 3, 2024
@youtalk youtalk marked this pull request as ready for review December 3, 2024 01:27
@youtalk youtalk requested a review from oguzkaganozt as a code owner December 3, 2024 01:27
@youtalk youtalk requested review from xmfcx and mitsudome-r December 3, 2024 01:27
@youtalk youtalk mentioned this pull request Dec 3, 2024
Merged
1 task
@youtalk youtalk merged commit 9185662 into autowarefoundation:main Dec 3, 2024
40 checks passed
@youtalk youtalk deleted the not-push-manifest branch December 3, 2024 01:58
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Dec 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitsudome-r mitsudome-r mitsudome-r approved these changes

@oguzkaganozt oguzkaganozt Awaiting requested review from oguzkaganozt oguzkaganozt is a code owner

@xmfcx xmfcx Awaiting requested review from xmfcx

Assignees

@youtalk youtalk

Labels
component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.
Projects
Open AD Kit Working Group
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youtalk @mitsudome-r