-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(autoware.repos): fix autoware.universe
and autoware_launch
versions to 0.38.0
#5435
Conversation
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
This reverts commit 87fb103.
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
c3d5037
to
3746713
Compare
See my comments here: |
I think this PR needs to be revised since
|
…sioning Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
@xmfcx It's ready to review! |
This reverts commit 0dd0883.
@youtalk -san, Looks good overall but since this revert was required, should we maintain 2 different autoware/docker/Dockerfile's too? Because the dockerfile is referring to package names. In stable and nightly .repos, they will point to different packages. (prefix vs non-prefix or maybe new packages will be added). With the current setup, it is not possible to pass both of these at the same time: |
@xmfcx Based on that way of thinking, we would also need to maintain two The branch names in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (2)
- autoware.repos: Language not supported
- docker/Dockerfile: Language not supported
I made the |
Description
autoware-nightly.repos
#5440Based on the discussion https://github.com/orgs/autowarefoundation/discussions/5292, we will fix the versions of
autoware.universe
andautoware_launch
.Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.