Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(autoware.repos): fix autoware.universe and autoware_launch versions to 0.38.0 #5435

Closed
wants to merge 17 commits into from

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Nov 14, 2024

Description

Based on the discussion https://github.com/orgs/autowarefoundation/discussions/5292, we will fix the versions of autoware.universe and autoware_launch.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk self-assigned this Nov 14, 2024
@youtalk youtalk added version:autoware-universe Autoware Universe component:launch Launch files, scripts and initialization tools. (auto-assigned) type:installation Issues or improvements related to the installation process of the software. type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check labels Nov 14, 2024
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
This reverts commit 87fb103.
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk changed the base branch from main to autoware-nightly November 15, 2024 05:50
@youtalk youtalk marked this pull request as ready for review November 15, 2024 05:51
@youtalk youtalk force-pushed the universe-launch-versioning branch from c3d5037 to 3746713 Compare November 15, 2024 06:03
@youtalk youtalk requested a review from xmfcx November 15, 2024 07:06
@xmfcx
Copy link
Contributor

xmfcx commented Nov 15, 2024

See my comments here:

Base automatically changed from autoware-nightly to main November 19, 2024 12:05
@xmfcx
Copy link
Contributor

xmfcx commented Nov 19, 2024

I think this PR needs to be revised since

@xmfcx xmfcx marked this pull request as draft November 19, 2024 13:21
@youtalk youtalk marked this pull request as ready for review November 19, 2024 23:26
@youtalk
Copy link
Member Author

youtalk commented Nov 19, 2024

@xmfcx It's ready to review!

@xmfcx
Copy link
Contributor

xmfcx commented Nov 20, 2024

@youtalk -san, Looks good overall but since this revert was required, should we maintain 2 different autoware/docker/Dockerfile's too?

Because the dockerfile is referring to package names. In stable and nightly .repos, they will point to different packages. (prefix vs non-prefix or maybe new packages will be added).

With the current setup, it is not possible to pass both of these at the same time:
image

@youtalk
Copy link
Member Author

youtalk commented Nov 21, 2024

@xmfcx Based on that way of thinking, we would also need to maintain two ansible directories, which we want to avoid.
In that case, I think it would be better to separate the main branch for providing a stable version and the development branch for providing the nightly version.

The branch names in awf/autoware.universe are humble for the stable version and main for the nightly version, so aligning with that might make things less confusing.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • autoware.repos: Language not supported
  • docker/Dockerfile: Language not supported
@youtalk
Copy link
Member Author

youtalk commented Nov 25, 2024

I made the 0.39.0 version PR #5479 instead.

@youtalk youtalk closed this Nov 25, 2024
@youtalk youtalk deleted the universe-launch-versioning branch November 25, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration. type:installation Issues or improvements related to the installation process of the software. version:autoware-universe Autoware Universe
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants