Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use codebuild for arm64 workflows #5122

Closed
wants to merge 5 commits into from
Closed

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Aug 23, 2024

Description

Follow up from:

  • ci: use aws codebuild autoware.universe#8498

  • Removing ./.github/actions/free-disk-space step since it is not relevant for CodeBuild machines. That action is optimized for Standard GitHub Runners.

  • CodeBuild machines may lose connection with GitHub Actions manager when CPU/Memory resources are drained.

    • For this, we should utilize taskset to use 1 less core than available cores.
    • This will most likely happen only for the colcon build step in the dockerfile when it builds.
    • I couldn't find a way to do this elegantly for this PR. So I will leave as is for now.

Tests performed

apt cmd not found.

https://docs.aws.amazon.com/codebuild/latest/userguide/sample-github-action-runners-update-yaml.images.html

Here are all the images and there is no Ubuntu compute image with arm support.

I've picked arm-3.0-large which is a Amazon Linux 2023 machine.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: M. Fatih Cırıt <[email protected]>
@xmfcx xmfcx self-assigned this Aug 23, 2024
@xmfcx xmfcx added the tag:run-health-check Run health-check label Aug 23, 2024
M. Fatih Cırıt added 4 commits August 23, 2024 16:38
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
@xmfcx xmfcx marked this pull request as draft August 23, 2024 14:35
@xmfcx xmfcx removed the tag:run-health-check Run health-check label Aug 23, 2024
@xmfcx
Copy link
Contributor Author

xmfcx commented Aug 23, 2024

I give up on this for now.

Maybe this could be achieved by creating another codebuild project with a managed ubuntu 22.04 arm image on their arm machines. But for now this is too much effort.

Let's keep using the perpetual machine for these tasks.

@xmfcx xmfcx closed this Aug 23, 2024
@xmfcx xmfcx deleted the ci/switch-to-codebuild branch August 23, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant