feat(docker): copy src
by --mount=type=bind
instead of COPY
#5027
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following the discussion https://github.com/orgs/autowarefoundation/discussions/5007#discussioncomment-10126509, this PR changes not to include
src
in theautoware-universe
image, and only include it in thedevel
image.However, due to the effects of previous PR #5009, the amount of
src
copied has already been minimized, resulting in a reduction of only 18.69MB in the image size.@xmfcx As a result, I think it would be convenient to keep
src
copied in theautoware-universe
image and not merge this PR, as it would make using theautoware-universe
as a development container easier.Tests performed
Before this PR merged:
autoware-universe
: https://hub.docker.com/layers/youtalk/autoware/20240723-autoware-universe-amd64/images/sha256-b9cf2acf7d466d257acffbd9c11f2c9317d091e24b1ee20cdfd1af615038bca0?context=repodevel
: https://hub.docker.com/layers/youtalk/autoware/20240723-devel-amd64/images/sha256-006a5022b3838781ba7ed875a948046663362b87a51eae3bd598734cc8e8180f?context=repoAfter this PR merged:
autoware-universe
: https://hub.docker.com/layers/youtalk/autoware/20240724-autoware-universe-amd64/images/sha256-ec2ecad973ba87421fba188aed60abd383b7e3b5ca68a07df85beaca716b949c?context=repodevel
: https://hub.docker.com/layers/youtalk/autoware/20240724-devel-amd64/images/sha256-64fe8d87607dad2145e9b6e48f05cada9689a13eba13725b870edf9fd1480631?context=repoEffects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.