Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fix Docker image organization #5002

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Jul 17, 2024

Description

#4865 and #4961 mistakenly replaced parts of what should have been github.repository_owner with github.actor. As a result, the docker-build-and-push workflow is failing.

ERROR: failed to solve: failed to push ghcr.io/youtalk/autoware:20240717-autoware-universe-cuda-amd64: unexpected status from POST request to https://ghcr.io/v2/youtalk/autoware/blobs/uploads/: 403 Forbidden

https://github.com/autowarefoundation/autoware/actions/runs/9969218788/job/27545808443#step:5:9436

This PR reverts those changes.

https://github.com/autowarefoundation/autoware/actions/runs/9974064666

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk self-assigned this Jul 17, 2024
@youtalk youtalk added type:bug Software flaws or errors. type:ci Continuous Integration (CI) processes and testing. labels Jul 17, 2024
@youtalk youtalk marked this pull request as ready for review July 17, 2024 12:30
@youtalk youtalk requested a review from oguzkaganozt as a code owner July 17, 2024 12:30
@youtalk youtalk requested review from xmfcx and mitsudome-r July 17, 2024 12:32
@youtalk youtalk added the tag:run-health-check Run health-check label Jul 17, 2024
@xmfcx
Copy link
Contributor

xmfcx commented Jul 17, 2024

Is it possible to tag this branch to see if docker build and push can build and push the image? Once it pushes the image, we can merge it.

@youtalk
Copy link
Member Author

youtalk commented Jul 17, 2024

@xmfcx Please hold on an hour https://github.com/autowarefoundation/autoware/actions/runs/9974064666.

@youtalk
Copy link
Member Author

youtalk commented Jul 17, 2024

Oh, it was failed due to another reason...
From my several months experience, docker/bake-action, which is used in docker-build-and-push workflow, tends to cause more problems than docker/build-push-action, which is used in health-check workflow. I will invalidate the relevant cache.

https://github.com/autowarefoundation/autoware/actions/runs/9974064666/job/27560776559#step:5:10093

105.1 fatal: [localhost]: FAILED! => {"changed": false, "msg": "Failed to lock apt for exclusive operation: Failed to lock directory /var/lib/apt/lists/: E:Could not open lock file /var/lib/apt/lists/lock - open (2: No such file or directory)"}

@youtalk
Copy link
Member Author

youtalk commented Jul 18, 2024

@xmfcx I am continuing to address the issue where the docker-build-and-push fails due to disk space problems in subsequent PRs #5004 and #5005, but I want to merge this PR first as it is just a bug fix.

@youtalk youtalk merged commit d5e9bc1 into main Jul 18, 2024
32 of 37 checks passed
@youtalk youtalk deleted the fix-image-organization branch July 18, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-health-check Run health-check type:bug Software flaws or errors. type:ci Continuous Integration (CI) processes and testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants