Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fix inline expansion of date tag #4979

Closed
wants to merge 1 commit into from
Closed

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Jul 12, 2024

Description

This PR fixes the bug where the date tag is not expanded inline due to the lack of writing $ prefix.

https://github.com/youtalk/autoware/actions/runs/9886057164/job/27305134747#step:5:480

Run docker/metadata-action@v5
  with:
    images: ghcr.io/youtalk/autoware
    tags: {{date 'YYYYMMDD'}}
  latest
  latest-humble
    bake-target: docker-metadata-action-base
    flavor: latest=false
  suffix=-base

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk self-assigned this Jul 12, 2024
@youtalk youtalk requested review from xmfcx and mitsudome-r July 12, 2024 05:42
@youtalk youtalk added type:ci Continuous Integration (CI) processes and testing. type:containers Docker containers, containerization of components, or container orchestration. labels Jul 12, 2024
@youtalk youtalk marked this pull request as ready for review July 12, 2024 05:42
@youtalk youtalk requested a review from oguzkaganozt as a code owner July 12, 2024 05:42
@youtalk youtalk added the tag:run-health-check Run health-check label Jul 12, 2024
@youtalk youtalk enabled auto-merge (squash) July 12, 2024 05:53
@youtalk youtalk disabled auto-merge July 12, 2024 07:46
@youtalk youtalk closed this Jul 12, 2024
@youtalk youtalk deleted the fix-tag-date branch July 12, 2024 07:46
@youtalk
Copy link
Member Author

youtalk commented Jul 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-health-check Run health-check type:ci Continuous Integration (CI) processes and testing. type:containers Docker containers, containerization of components, or container orchestration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant