Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fix ccache cache key #4977

Merged
merged 2 commits into from
Jul 12, 2024
Merged

fix(ci): fix ccache cache key #4977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3a072b
fix ccache key
youtalk Jul 11, 2024
fb22410
move todo comments
youtalk Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/actions/docker-build-and-push/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ runs:
- name: Setup Docker Buildx
uses: docker/setup-buildx-action@v3

# TODO(youtalk): Remove obsolete "cache-" restore-keys
- name: Restore ccache
uses: actions/cache/restore@v4
with:
Expand All @@ -53,8 +54,8 @@ runs:
restore-keys: |
ccache-${{ inputs.platform }}-${{ inputs.name }}-
ccache-${{ inputs.platform }}-
cache-${{ inputs.platform }}-${{ inputs.name }}- # TODO(youtalk): Remove obsolete cache key
cache-${{ inputs.platform }}- # TODO(youtalk): Remove obsolete cache key
cache-${{ inputs.platform }}-${{ inputs.name }}-
cache-${{ inputs.platform }}-

- name: Restore apt-get
uses: actions/cache/restore@v4
Expand Down
12 changes: 7 additions & 5 deletions .github/actions/docker-build/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,19 +34,20 @@
vcs import src < autoware.repos
shell: bash

# TODO(youtalk): Remove obsolete "cache-" restore-keys
- name: Cache ccache
uses: actions/cache@v4
if: ${{ inputs.name == 'no-cuda' }}
id: cache-ccahce

Check warning on line 41 in .github/actions/docker-build/action.yaml

View workflow job for this annotation

GitHub Actions / spell-check-differential 

Unknown word (ccahce)
with:
path: |
root-ccache
key: cache-${{ inputs.platform }}-${{ inputs.name }}-${{ hashFiles('src/**/*.cpp') }}
key: ccache-${{ inputs.platform }}-${{ inputs.name }}-${{ hashFiles('src/**/*.cpp') }}
restore-keys: |
ccache-${{ inputs.platform }}-${{ inputs.name }}-
ccache-${{ inputs.platform }}-
cache-${{ inputs.platform }}-${{ inputs.name }}- # TODO(youtalk): Remove obsolete cache key
cache-${{ inputs.platform }}- # TODO(youtalk): Remove obsolete cache key
cache-${{ inputs.platform }}-${{ inputs.name }}-
cache-${{ inputs.platform }}-

- name: Cache apt-get
uses: actions/cache@v4
Expand All @@ -61,6 +62,7 @@
apt-get-${{ inputs.platform }}-${{ inputs.name }}-
apt-get-${{ inputs.platform }}-

# TODO(youtalk): Remove obsolete "cache-" restore-keys
- name: Restore ccache
uses: actions/cache/restore@v4
if: ${{ inputs.name != 'no-cuda' }}
Expand All @@ -71,8 +73,8 @@
restore-keys: |
ccache-${{ inputs.platform }}-${{ inputs.name }}-
ccache-${{ inputs.platform }}-
cache-${{ inputs.platform }}-${{ inputs.name }}- # TODO(youtalk): Remove obsolete cache key
cache-${{ inputs.platform }}- # TODO(youtalk): Remove obsolete cache key
cache-${{ inputs.platform }}-${{ inputs.name }}-
cache-${{ inputs.platform }}-

- name: Restore apt-get
uses: actions/cache/restore@v4
Expand Down
Loading