Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): change ccache cache key to update the cache more precisely #4969

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Jul 11, 2024

Description

The contents of ccache cache have not been updated for two weeks, causing the execution time of colcon build to gradually increase.
This is because the current cache key does not update unless autoware.repos is updated.

https://autowarefoundation.github.io/autoware-ci-metrics/
Screenshot from 2024-07-11 09-59-54

https://github.com/autowarefoundation/autoware/actions/caches
Screenshot from 2024-07-11 10-01-29

Therefore, in this PR, instead of using autoware.repos for the hash calculation of the cache key, all .cpp files under the src directory will be used. This change will update the cache key when the source code is modified, ensuring that ccache cache is also updated.

Tests performed

https://github.com/youtalk/autoware/actions/runs/9883864849

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk self-assigned this Jul 11, 2024
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk marked this pull request as ready for review July 11, 2024 01:22
@youtalk youtalk requested a review from oguzkaganozt as a code owner July 11, 2024 01:22
@youtalk youtalk requested review from xmfcx and mitsudome-r July 11, 2024 01:22
@youtalk youtalk merged commit 3b343c2 into main Jul 11, 2024
13 checks passed
@youtalk youtalk deleted the change-cache-key branch July 11, 2024 06:23
pravinkmr26 pushed a commit to pravinkmr26/autoware that referenced this pull request Jul 15, 2024
autowarefoundation#4969)

* hash cpp files

Signed-off-by: Yutaka Kondo <[email protected]>

* add src prefix

Signed-off-by: Yutaka Kondo <[email protected]>

---------

Signed-off-by: Yutaka Kondo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants