Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): make sure tag:run-health-check tag is present on PR to run health-check CI #4962

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Jul 10, 2024

Description

The health-check workflow, formerly known as build-main, now consistently completes in an hour and a half thanks to the activation of GitHub Actions cache. By further utilizing the multi-containerization and the docker layer cache, it could become even faster.
https://autowarefoundation.github.io/autoware-ci-metrics/

Therefore, to ensure the code quality of Autoware, I would like to add the health-check check as a merge condition for PRs.
This PR will make the health-check run when the tag:run-health-check tag is attached.

Tests performed

Before attaching tag:run-health-check
Screenshot from 2024-07-10 15-48-31

After attaching tag:run-health-check
Screenshot from 2024-07-10 15-49-43

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

youtalk added 2 commits July 10, 2024 15:32
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk self-assigned this Jul 10, 2024
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk added the tag:run-health-check Run health-check label Jul 10, 2024
@youtalk youtalk marked this pull request as ready for review July 10, 2024 06:54
@youtalk youtalk requested a review from oguzkaganozt as a code owner July 10, 2024 06:54
@youtalk youtalk requested review from xmfcx and mitsudome-r July 10, 2024 06:54
@youtalk youtalk merged commit 7ec614e into main Jul 11, 2024
22 checks passed
@youtalk youtalk deleted the upstream-health-check-pr branch July 11, 2024 06:24
pravinkmr26 pushed a commit to pravinkmr26/autoware that referenced this pull request Jul 15, 2024
…n `health-check` CI (autowarefoundation#4962)

* check tag

Signed-off-by: Yutaka Kondo <[email protected]>

* run only github hosted runner

Signed-off-by: Yutaka Kondo <[email protected]>

* check result

Signed-off-by: Yutaka Kondo <[email protected]>

---------

Signed-off-by: Yutaka Kondo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-health-check Run health-check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants