Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): save cache on no-cuda jobs and restore cache only on cuda jobs #4945

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Jul 4, 2024

Description

Resolves #4944

This PR saves the buildkit-cache-dance cache only on no-cuda jobs and only restore the cache on cuda jobs.

Tests performed

https://github.com/youtalk/autoware/actions/runs/9786429625

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk added the type:ci Continuous Integration (CI) processes and testing. label Jul 4, 2024
@youtalk youtalk self-assigned this Jul 4, 2024
@youtalk youtalk requested a review from oguzkaganozt as a code owner July 4, 2024 00:33
@youtalk youtalk requested review from xmfcx and mitsudome-r July 4, 2024 00:34
youtalk added 2 commits July 4, 2024 10:11
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk requested a review from xmfcx July 4, 2024 06:57
@youtalk youtalk enabled auto-merge (squash) July 4, 2024 08:18
Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary in #4945 (comment)

@youtalk youtalk merged commit 6fc986e into main Jul 4, 2024
13 checks passed
@youtalk youtalk deleted the restore-only-on-cuda branch July 4, 2024 15:08
youtalk added a commit to youtalk/autoware that referenced this pull request Jul 5, 2024
* feat(ci): save cache on `no-cuda` jobs and restore cache only on `cuda` jobs (autowarefoundation#4945)

* feat(ci): rename `docker build` workflows (autowarefoundation#4947)

* cache only on no-cuda

Signed-off-by: Yutaka Kondo <[email protected]>

* version up

Signed-off-by: Yutaka Kondo <[email protected]>

* version up

Signed-off-by: Yutaka Kondo <[email protected]>

* rename

Signed-off-by: Yutaka Kondo <[email protected]>

* rename

Signed-off-by: Yutaka Kondo <[email protected]>

* rename to health-check

Signed-off-by: Yutaka Kondo <[email protected]>

---------

Signed-off-by: Yutaka Kondo <[email protected]>

* refactor(ci): refactor `docker-build-and-push` action (autowarefoundation#4948)

* cache only on no-cuda

Signed-off-by: Yutaka Kondo <[email protected]>

* version up

Signed-off-by: Yutaka Kondo <[email protected]>

* version up

Signed-off-by: Yutaka Kondo <[email protected]>

* rename

Signed-off-by: Yutaka Kondo <[email protected]>

* rename

Signed-off-by: Yutaka Kondo <[email protected]>

* rename to health-check

Signed-off-by: Yutaka Kondo <[email protected]>

* refactor action

Signed-off-by: Yutaka Kondo <[email protected]>

* remove old comment

Signed-off-by: Yutaka Kondo <[email protected]>

* revert free disk

Signed-off-by: Yutaka Kondo <[email protected]>

---------

Signed-off-by: Yutaka Kondo <[email protected]>

---------

Signed-off-by: Yutaka Kondo <[email protected]>
pravinkmr26 pushed a commit to pravinkmr26/autoware that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:ci Continuous Integration (CI) processes and testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only cuda jobs generate empty cache on build-main and build-main-self-hosted workflows
2 participants