Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): update docker/login-action to fix Node.js deprecation #4903

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Jun 24, 2024

Description

This PR updates docker/login-action to fix the GitHub Actions' warning.
Screenshot from 2024-06-24 10-26-24

Tests performed

There is no warning errors after merging this PR.
https://github.com/youtalk/autoware/actions/runs/9609252290

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk requested a review from oguzkaganozt as a code owner June 24, 2024 01:28
@youtalk youtalk self-assigned this Jun 24, 2024
Copy link
Contributor

@oguzkaganozt oguzkaganozt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oguzkaganozt oguzkaganozt merged commit 873857c into main Jun 24, 2024
15 checks passed
@oguzkaganozt oguzkaganozt deleted the update-docker-login-action branch June 24, 2024 09:15
pravinkmr26 pushed a commit to pravinkmr26/autoware that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants