Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): update docker/bake-action and docker/build-push-action versions to enable GitHub Actions build summary #4898

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Jun 21, 2024

Description

This PR updates docker actions for GitHub Actions to enable GitHub Actions build summary by docker build.
https://docs.docker.com/build/ci/github-actions/build-summary/

Tests performed

I tried it in my forked repository, and it was easy to check the cache usage, build time, and bake definitions.
https://github.com/youtalk/autoware/actions/runs/9607362250?pr=52

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

youtalk added 2 commits June 21, 2024 12:37
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk requested a review from oguzkaganozt as a code owner June 21, 2024 03:51
@youtalk youtalk self-assigned this Jun 21, 2024
@youtalk youtalk requested review from xmfcx and mitsudome-r June 21, 2024 03:52
@youtalk youtalk changed the title feat(ci): update docker/bake-action and docker/build-push-action to enable GitHub Actions build summary feat(ci): update docker/bake-action and docker/build-push-action versions to enable GitHub Actions build summary Jun 21, 2024
Copy link
Contributor

@oguzkaganozt oguzkaganozt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @youtalk ! LGTM

@oguzkaganozt oguzkaganozt merged commit 1d6c9a0 into main Jun 21, 2024
17 checks passed
@oguzkaganozt oguzkaganozt deleted the upstream-update-docker-actions branch June 21, 2024 11:29
pravinkmr26 pushed a commit to pravinkmr26/autoware that referenced this pull request Jul 15, 2024
…versions to enable GitHub Actions build summary (autowarefoundation#4898)

* update docker actions

Signed-off-by: Yutaka Kondo <[email protected]>

* update docker actions

Signed-off-by: Yutaka Kondo <[email protected]>

---------

Signed-off-by: Yutaka Kondo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants