ci(docker-build-and-push): add base tag to fix failure #4886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 18, 2024 17:41
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
xmfcx
commented
Jun 18, 2024
xmfcx
commented
Jun 18, 2024
xmfcx
commented
Jun 18, 2024
xmfcx
added
type:ci
4 tasks
|
🎈🎈🎈🎈Success 🖱️Click here to expand🔛
@youtalk @oguzkaganozt this is ready for review, it seems to have succeed building and pushing the image. |
Co-authored-by: Yutaka Kondo <[email protected]>
|
@youtalk san thank you for the review! |
pravinkmr26
pushed a commit
to pravinkmr26/autoware
that referenced
this pull request
Jul 15, 2024
…ation#4886) Signed-off-by: M. Fatih Cırıt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes:
docker-build-and-push-mainis failing #4879Tests performed
To test this, I've created this tag temporarily:
Workflow triggered by that tag push:
And
tagis underpushcondition so it should test it very comprehensively.I don't know if it will have any side effects but we'll see.
I'll remove the images once this PR is merged.
🎈🎈🎈🎈Success
🖱️Click here to expand🔛
Effects on system behavior
Hopefully CI starts working again.
Interface changes
None.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.