chore(docker): change the cmake's build tool from make to ninja
#4658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yutaka Kondo <[email protected]>
youtalk
force-pushed
the
cmake-args-ninja
branch
from
4a099bc to
6759b18
Compare
|
|
|
Is ninja installed on the system? Could you share the step that installs it? |
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
|
@youtalk -san, why was this closed? |
|
@xmfcx Just no reason. I’ve reopened. Please review again. |
|
@youtalk why did you remove it this time? |
|
Because no one reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has changed the cmake's build tool from
maketoninja.ninjais typically faster thanmaketo rebuild modified source code.So when using cache properly, the
ninjabuild time would be faster thanmake.https://ninja-build.org/
The results of the
colcon buildtime using my local PC are shown below. There may be a few overhead.make: 40min 59.55sninja: 41min 57.07sTests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.