-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(docker): introduce rosdep-installed stage #4656
Conversation
4a73e1c
to
7599c03
Compare
|
@oguzkaganozt Did you have any reasons for running rosdep twice in prebuilt and runtime steps? |
Signed-off-by: Yutaka Kondo <[email protected]>
02801f3
to
7b53926
Compare
First, rosdep installs build dependencies for devel image. Second, rosdep installs runtime (exec) dependencies for runtime image. This separation is very important. |
I am planning an apt package release of the Autoware packages. Once that is completed, we will be able to control the build and execution dependencies you mentioned. |
This is the PR that adds the support to dependency key selection: ros-infrastructure/rosdep#789 And we can use:
Whether |
@doganulus Thank you for your feedback. I didn't know the option. Due to the rosdep install separation, I've closed this PR. |
Description
This PR introduces the
rosdep-installed
stage before theprebuilt
stage to executerosdep install
only one time.Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.