Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker): remove duplicate ARG ROS_DISTRO #4649

Merged

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Apr 23, 2024

Description

This PR has just removed duplicate lines of ARG ROS_DISTRO.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk self-assigned this Apr 23, 2024
@youtalk youtalk changed the title chore(docker): Remove rduplicate ARG ROS_DISTRO chore(docker): remove duplicate ARG ROS_DISTRO Apr 23, 2024
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk force-pushed the remove-redundant-rosdistro branch from 68302fa to 419cab9 Compare April 23, 2024 04:00
@youtalk youtalk marked this pull request as ready for review April 23, 2024 04:07
Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsudome-r mitsudome-r merged commit 6dc56cc into autowarefoundation:main Apr 23, 2024
12 of 13 checks passed
@youtalk youtalk deleted the remove-redundant-rosdistro branch April 23, 2024 05:40
oguzkaganozt pushed a commit that referenced this pull request Apr 30, 2024
* remove ROS_DISTRO twice

Signed-off-by: Yutaka Kondo <[email protected]>

* empty

Signed-off-by: Yutaka Kondo <[email protected]>

---------

Signed-off-by: Yutaka Kondo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants