Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore node_modules folder #4628

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

Naophis
Copy link
Contributor

@Naophis Naophis commented Apr 16, 2024

Description

The pre-commit, a GitHub Action, generates a temporary file similar to node_modules/.cache/prettier/.prettier-caches/~~~~.json, which is then automatically committed.
This pull request prevents the commit of temporary files in the node_modules folder.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@Naophis Naophis requested review from shmpwk and tkimura4 April 16, 2024 02:32
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk shmpwk changed the title feat: ignore node_modules folder chore: ignore node_modules folder Apr 16, 2024
@shmpwk shmpwk enabled auto-merge (squash) April 16, 2024 02:50
auto-merge was automatically disabled April 16, 2024 02:50

Head branch was pushed to by a user without write access

@Naophis Naophis force-pushed the feat/ommit-node_modules branch from 523f800 to 413a8f0 Compare April 16, 2024 02:50
@shmpwk shmpwk merged commit 9866356 into autowarefoundation:main Apr 16, 2024
12 of 13 checks passed
@Naophis Naophis deleted the feat/ommit-node_modules branch April 16, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants