-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ansible): set default value for install_dev variable #4607
feat(ansible): set default value for install_dev variable #4607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opionion, the name of "install_dev" needs more refactoring.
For the time being, "install_dev" is the flag for installing dev_tools (git lfs, pre-commit, clang-format and so on), and also nvidia cudnn/tensorrt.
The problem is that git-lfs, pre-commit are indeed development tools that is not required in run time, while nvidia cudnn / tensorrt is required for full usage of autoware.
We need to divide the usage of this variable before we add more modifications on its pre-defined value
I think scenario testing might not be working due to missing |
Actually right now it is installing only runtime bindings both for CUDA and tensorRT but not dev packages and header files, so cuda and tensorRT dependent packages should work without any problem. Last time I tested I couldn't see any problems related to these packages. If you have any related issues could you please share ? Thanks for the feedback, @Owen-Liuyuxuan |
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
e75bbcb
to
d542d16
Compare
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat(ansible): set default value for install_dev variable Signed-off-by: Ryohsuke Mitsudome <[email protected]> * fix: change true to 'y' for prompting install_devel Signed-off-by: Ryohsuke Mitsudome <[email protected]> * style(pre-commit): autofix * fix: fix pre-commit error Signed-off-by: Ryohsuke Mitsudome <[email protected]> --------- Signed-off-by: Ryohsuke Mitsudome <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
Due to the refactoring, it seems like the evaluator for testing scenario testing is failing.
It seems like it is due to change in expected variables for universe playbook, where the refactored version expects
install_devel
to be set.I modified the playbook to set true as default.
However, the modification now prompts the user to install dev_tools. If there are any other way to set default value for the variable without prompting, please let me know.
Tests performed
Tested locally with ./setup-dev-env.sh, and tested with the evaluator.
Effects on system behavior
The new script now prompts the user to install dev_tools when the script is executed.
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.