feat(ansible): add new task to install libqt5charts5-dev #4119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: satoshi-ota <[email protected]>
|
Could you explain in the description why you want to add this package? Please link to the issue or PR that requires this library to be installed. |
@mitsudome-r Thanks your comment. I added the related PR in the description. |
mitsudome-r
approved these changes
Jan 25, 2024
|
@satoshi-ota -san could you also update the ansible/roles/autoware_universe/README.md file as well? Those are used in the Manual Installation Instructions. |
oguzkaganozt
pushed a commit
that referenced
this pull request
Feb 19, 2024
Signed-off-by: satoshi-ota <[email protected]> Signed-off-by: Oguz Ozturk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new task to install
libqt5charts5-devso that we can develop utility tools with qt charts.Related PR: autowarefoundation/autoware.universe#6154 (I use the lib in this PR.)
NOTE: After merging ros/rosdistro#39705, I'll remove this task.
Tests performed
I confirmed that
libqt5charts5-devwas installed correctly with./setup-dev-env.sh.Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.