Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autoware_control_evaluator): fix bugprone-exception-escape #9630

Merged
merged 2 commits into from
Dec 16, 2024
Merged

fix(autoware_control_evaluator): fix bugprone-exception-escape #9630

merged 2 commits into from
Dec 16, 2024

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on clang-tidy bugprone-exception-escape error.

/home/emb4/autoware/autoware/src/universe/autoware.universe/evaluator/autoware_control_evaluator/src/control_evaluator_node.cpp:49:23: error: an exception may be thrown in function '~ControlEvaluatorNode' which should not throw exceptions [bugprone-exception-escape,-warnings-as-errors]
ControlEvaluatorNode::~ControlEvaluatorNode()
                      ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) label Dec 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@takayuki5168
Copy link
Contributor

@xtk8532704
Can you review the PR?

@kobayu858
fix: cpplint
df6c1d9 
Signed-off-by: kobayu858 <[email protected]>
@kobayu858 kobayu858 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 12, 2024
@kobayu858 kobayu858 requested a review from veqcc December 12, 2024 05:52
@codecov Codecov
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 29.55%. Comparing base (e30350c) to head (df6c1d9).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...e_control_evaluator/src/control_evaluator_node.cpp 0.00% 25 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9630      +/-   ##
==========================================
- Coverage   29.56%   29.55%   -0.01%     
==========================================
  Files        1441     1442       +1     
  Lines      108348   108383      +35     
  Branches    41376    41391      +15     
==========================================
+ Hits        32032    32033       +1     
- Misses      73206    73241      +35     
+ Partials     3110     3109       -1
Flag Coverage Δ *Carryforward flag
differential 2.70% <0.00%> (?)
total 29.57% <ø> (+<0.01%) ⬆️ Carriedforward from e30350c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kobayu858
Copy link
Contributor Author

@xtk8532704
Please confirm the PR. Thank you very much.

xtk8532704
xtk8532704 approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@xtk8532704 xtk8532704 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR very much.

@kobayu858 kobayu858 merged commit 9167bfb into autowarefoundation:main Dec 16, 2024
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xtk8532704 xtk8532704 xtk8532704 approved these changes

@danielsanchezaran danielsanchezaran Awaiting requested review from danielsanchezaran danielsanchezaran is a code owner

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

@veqcc veqcc Awaiting requested review from veqcc

Assignees

@xtk8532704 xtk8532704

Labels
component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Software Working Group
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kobayu858 @takayuki5168 @xtk8532704