fix(autoware_tensorrt_yolox): modify tensorrt_yolox_node name #9156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:perception
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
cyn-liu
added
run:build-and-test-differential
3 tasks
Signed-off-by: liu cui <[email protected]>
…_transport_decompressor Signed-off-by: liu cui <[email protected]>
xmfcx
force-pushed
the
fix/issue9146-tensorrt_yolox_node
branch
from
3c37dd8 to
57ddd14
Compare
|
Since the reviewers are not making reviews for over a week, I have reviewed it as an Autoware maintainer. The modification shouldn't have effects on autoware_launch, and it also adds the original node name as the default name. I will merge it once the CIs pass. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9156 +/- ##
==========================================
+ Coverage 29.44% 29.47% +0.02%
==========================================
Files 1444 1444
Lines 108617 108242 -375
Branches 42425 42172 -253
==========================================
- Hits 31983 31904 -79
+ Misses 73547 73259 -288
+ Partials 3087 3079 -8
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
esteve
pushed a commit
to esteve/autoware.universe
that referenced
this pull request
Jan 15, 2025
…refoundation#9156) Signed-off-by: liu cui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When use
multiple_yolox.launch.xmllaunch manytensorrt_yoloxnode, the names of these nodes are same.Solution:
Adding two parameters
yolox_node_nameandimage_transport_decompressor_node_namefor node name inyolox_s_plus_opt.launch.xmland explicitly assign them inmultiple_yolox.launch.xml.Related links
9146
How was this PR tested?
Run the following command for testing:
ros2 launch autoware_tensorrt_yolox multiple_yolox.launch.xmlros2 node listNotes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.