Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autoware_tensorrt_yolox): modify tensorrt_yolox_node name #9156

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(autoware_tensorrt_yolox): modify tensorrt_yolox_node name #9156

wants to merge 3 commits into from
+20 −2

Conversation

cyn-liu
Copy link
Contributor

@cyn-liu cyn-liu commented Oct 25, 2024 •
edited
Loading

Description

When use multiple_yolox.launch.xml launch many tensorrt_yolox node, the names of these nodes are same.

Solution:
Adding two parameters yolox_node_name and image_transport_decompressor_node_name for node name in yolox_s_plus_opt.launch.xml and explicitly assign them in multiple_yolox.launch.xml.

Related links

9146

How was this PR tested?

Run the following command for testing:
ros2 launch autoware_tensorrt_yolox multiple_yolox.launch.xml
ros2 node list

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Oct 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 25, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@cyn-liu cyn-liu marked this pull request as draft October 25, 2024 06:49
@cyn-liu cyn-liu mentioned this pull request Oct 25, 2024
Open
3 tasks
@cyn-liu cyn-liu marked this pull request as ready for review November 22, 2024 07:44
@cyn-liu cyn-liu requested a review from badai-nguyen November 22, 2024 07:57
@cyn-liu cyn-liu added tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed tag:require-cuda-build-and-test labels Dec 5, 2024
@cyn-liu cyn-liu linked an issue Dec 5, 2024 that may be closed by this pull request
Too many nodes with same name #9146
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-dnn dan-dnn Awaiting requested review from dan-dnn dan-dnn is a code owner

@ktro2828 ktro2828 Awaiting requested review from ktro2828 ktro2828 is a code owner

@manato manato Awaiting requested review from manato manato is a code owner

@badai-nguyen badai-nguyen Awaiting requested review from badai-nguyen

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Software Working Group
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Too many nodes with same name
1 participant
@cyn-liu