Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing drivable area when two lanelets merged into one #8650

Open
3 tasks done
felixf4xu opened this issue Aug 28, 2024 · 7 comments
Open
3 tasks done

Missing drivable area when two lanelets merged into one #8650

felixf4xu opened this issue Aug 28, 2024 · 7 comments
Labels
component:map Map creation, storage, and loading. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned)

Comments

@felixf4xu
Copy link
Contributor

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I'm convinced that this is not my fault but a bug.

Description

I have a map where 2 lanes will merge into one, like this:
image
and it can be simplified as this:
image

Expected behavior

on dashed lines, lane change should be possible, all area should be drivable.

Actual behavior

image
There is some triangle area (circle in red), which is not drivable

Steps to reproduce

the lanelet map is uploaded
lanelet2_map.zip

Versions

  • Ubuntu 22
  • Humble
  • autoware main branch

Possible causes

in the overlapped area, it's difficult to tell which lanelets are neighbors

Additional context

No response

@felixf4xu
Copy link
Contributor Author

First of all, I would like to check if the map (lanelet) is drawn correctly, I mean, maybe there are some other ways to draw the lanelets so that autoware can successfully understand.

@maxime-clem maxime-clem added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) labels Aug 28, 2024
@mehmetdogru
Copy link
Contributor

Thank you @felixf4xu for creating the issue.

The map seems right to me.

For path planner to expand drivable area so that neighbor lanes as well would be covered, they should share a linestring at the moment. Since in your drawings lanelet 2 and 3 does not share a linesting drivable area is not expanded. I am not sure how easy to implement what you want.

@felixf4xu
Copy link
Contributor Author

That missing triangle area actually does not matter much when driving at 4-2-1 or 5-3-1, but it matters when checking if lane change is possible from 4 -> 5 or from 5 -> 4.

image

@maxime-clem
Copy link
Contributor

The map is fine but the current planning modules do not handle this case well.
To do the lane change with a merging lane, it is better to draw lanelet 2 as a triangle such that it does not have a successor but has an adjacent lanelet (required to do lane change).
image

I tested it and now we can do a lane change.
image

I could not find anything about merging lanes in the map creation requirements (https://docs.pilot.auto/en/reference-design/common/map-requirements/overview) so we should probably keep this issue open and either:

  • Add a requirement for merging lanes in the documentation.
  • Properly handle merging lanes represented with 2 lanelets preceding one lanelet.

Copy link

stale bot commented Oct 29, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Oct 29, 2024
@felixf4xu
Copy link
Contributor Author

I tested it and now we can do a lane change

Hi @maxime-clem , did you test it with some new code added? is the code already merged into some branch of autoware.universe?

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Oct 31, 2024
@maxime-clem
Copy link
Contributor

did you test it with some new code added?

No new code. I only modified the map file as I described.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:map Map creation, storage, and loading. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

No branches or pull requests

3 participants