Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(autoware_obstacle_stop_planner): prefix package and namespace with autoware #7565

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Jun 18, 2024

Description

See autowarefoundation/autoware#4569

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jun 18, 2024
@esteve esteve force-pushed the prefix-obstacle_stop_planner branch 2 times, most recently from c25119a to e242a51 Compare June 19, 2024 08:31
@esteve esteve marked this pull request as ready for review June 19, 2024 08:31
@esteve esteve added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 19, 2024
@esteve esteve force-pushed the prefix-obstacle_stop_planner branch from 4d2fbd9 to 136ffd6 Compare June 24, 2024 15:11
@esteve esteve enabled auto-merge (squash) June 24, 2024 15:11
@esteve esteve force-pushed the prefix-obstacle_stop_planner branch from 136ffd6 to 7dd4f1b Compare June 24, 2024 15:11
@esteve
Copy link
Contributor Author

esteve commented Jun 24, 2024

@satoshi-ota @shmpwk can you have a look at this PR when you have a moment? Thanks.

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 23.07692% with 10 lines in your changes missing coverage. Please review.

Project coverage is 28.29%. Comparing base (5bac5c6) to head (504f6ab).

Files Patch % Lines
...utoware_obstacle_stop_planner/src/debug_marker.cpp 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7565      +/-   ##
==========================================
- Coverage   28.37%   28.29%   -0.08%     
==========================================
  Files        1584     1592       +8     
  Lines      115598   117209    +1611     
  Branches    49276    50168     +892     
==========================================
+ Hits        32799    33170     +371     
- Misses      73795    75034    +1239     
- Partials     9004     9005       +1     
Flag Coverage Δ *Carryforward flag
differential 4.43% <23.07%> (?)
total 28.38% <ø> (+0.01%) ⬆️ Carriedforward from 644e7ee

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esteve esteve force-pushed the prefix-obstacle_stop_planner branch 2 times, most recently from 8e4c9bc to 312b9c3 Compare June 24, 2024 19:43
@esteve esteve force-pushed the prefix-obstacle_stop_planner branch from 312b9c3 to 1105f62 Compare June 25, 2024 09:56
Copy link

github-actions bot commented Jun 25, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@esteve
Copy link
Contributor Author

esteve commented Jun 26, 2024

@shmpwk I don't know why this PR hasn't been merged automatically after you approved it, do you know why?

@brkay54
Copy link
Member

brkay54 commented Jun 26, 2024

@esteve Hi, a required CI check named pre-commit.ci-pr was not passed.

cpplint..................................................................Failed
- hook id: cpplint
- exit code: 1

planning/autoware_obstacle_stop_planner/src/planner_utils.cpp:392:  Add #include <algorithm> for min  [build/include_what_you_use] [4]
planning/autoware_obstacle_stop_planner/src/planner_utils.cpp:569:  Add #include <limits> for numeric_limits<>  [build/include_what_you_use] [4]
Done processing planning/autoware_obstacle_stop_planner/src/planner_utils.cpp
Total errors found: 2
planning/autoware_obstacle_stop_planner/src/adaptive_cruise_control.cpp:430:  Add #include <utility> for make_pair  [build/include_what_you_use] [4]
Done processing planning/autoware_obstacle_stop_planner/src/adaptive_cruise_control.cpp
planning/autoware_obstacle_stop_planner/src/debug_marker.cpp:537:  Add #include <limits> for numeric_limits<>  [build/include_what_you_use] [4]
Done processing planning/autoware_obstacle_stop_planner/src/debug_marker.cpp
Total errors found: 2

@esteve esteve force-pushed the prefix-obstacle_stop_planner branch from 63df2d9 to a12b84e Compare July 1, 2024 09:43
@esteve
Copy link
Contributor Author

esteve commented Jul 1, 2024

@brkay54 thanks, the issues should be fixed in caf4196

@esteve esteve force-pushed the prefix-obstacle_stop_planner branch from cf8d82f to 644e7ee Compare July 2, 2024 08:10
Signed-off-by: Esteve Fernandez <[email protected]>
@esteve esteve merged commit fd28010 into autowarefoundation:main Jul 2, 2024
26 of 30 checks passed
@esteve esteve deleted the prefix-obstacle_stop_planner branch July 2, 2024 09:00
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jul 3, 2024
…e with autoware (autowarefoundation#7565)

* refactor(autoware_obstacle_stop_planner): prefix package and namespace with autoware

Signed-off-by: Esteve Fernandez <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
…e with autoware (autowarefoundation#7565)

* refactor(autoware_obstacle_stop_planner): prefix package and namespace with autoware

Signed-off-by: Esteve Fernandez <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: palas21 <[email protected]>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
…e with autoware (autowarefoundation#7565)

* refactor(autoware_obstacle_stop_planner): prefix package and namespace with autoware

Signed-off-by: Esteve Fernandez <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…e with autoware (#7565)

* refactor(autoware_obstacle_stop_planner): prefix package and namespace with autoware

Signed-off-by: Esteve Fernandez <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants