-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(autoware_obstacle_stop_planner): prefix package and namespace with autoware #7565
refactor(autoware_obstacle_stop_planner): prefix package and namespace with autoware #7565
Conversation
c25119a
to
e242a51
Compare
4d2fbd9
to
136ffd6
Compare
136ffd6
to
7dd4f1b
Compare
@satoshi-ota @shmpwk can you have a look at this PR when you have a moment? Thanks. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7565 +/- ##
==========================================
- Coverage 28.37% 28.29% -0.08%
==========================================
Files 1584 1592 +8
Lines 115598 117209 +1611
Branches 49276 50168 +892
==========================================
+ Hits 32799 33170 +371
- Misses 73795 75034 +1239
- Partials 9004 9005 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
8e4c9bc
to
312b9c3
Compare
312b9c3
to
1105f62
Compare
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
1105f62
to
6e0697d
Compare
1f15832
to
63df2d9
Compare
@shmpwk I don't know why this PR hasn't been merged automatically after you approved it, do you know why? |
@esteve Hi, a required CI check named cpplint..................................................................Failed
- hook id: cpplint
- exit code: 1
planning/autoware_obstacle_stop_planner/src/planner_utils.cpp:392: Add #include <algorithm> for min [build/include_what_you_use] [4]
planning/autoware_obstacle_stop_planner/src/planner_utils.cpp:569: Add #include <limits> for numeric_limits<> [build/include_what_you_use] [4]
Done processing planning/autoware_obstacle_stop_planner/src/planner_utils.cpp
Total errors found: 2
planning/autoware_obstacle_stop_planner/src/adaptive_cruise_control.cpp:430: Add #include <utility> for make_pair [build/include_what_you_use] [4]
Done processing planning/autoware_obstacle_stop_planner/src/adaptive_cruise_control.cpp
planning/autoware_obstacle_stop_planner/src/debug_marker.cpp:537: Add #include <limits> for numeric_limits<> [build/include_what_you_use] [4]
Done processing planning/autoware_obstacle_stop_planner/src/debug_marker.cpp
Total errors found: 2 |
63df2d9
to
a12b84e
Compare
…e with autoware Signed-off-by: Esteve Fernandez <[email protected]>
Signed-off-by: Esteve Fernandez <[email protected]>
cf8d82f
to
644e7ee
Compare
Signed-off-by: Esteve Fernandez <[email protected]>
…e with autoware (autowarefoundation#7565) * refactor(autoware_obstacle_stop_planner): prefix package and namespace with autoware Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Esteve Fernandez <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…e with autoware (autowarefoundation#7565) * refactor(autoware_obstacle_stop_planner): prefix package and namespace with autoware Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Esteve Fernandez <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: palas21 <[email protected]>
…e with autoware (autowarefoundation#7565) * refactor(autoware_obstacle_stop_planner): prefix package and namespace with autoware Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Esteve Fernandez <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…e with autoware (#7565) * refactor(autoware_obstacle_stop_planner): prefix package and namespace with autoware Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Esteve Fernandez <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
See autowarefoundation/autoware#4569
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.