Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radar_object_tracker launches even if no radar has been launched #7463

Closed
3 tasks done
mhmdrz-mirdamadi opened this issue Jun 12, 2024 · 2 comments
Closed
3 tasks done
Labels
status:stale Inactive or outdated issues. (auto-assigned) type:bug Software flaws or errors.

Comments

@mhmdrz-mirdamadi
Copy link
Contributor

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I'm convinced that this is not my fault but a bug.

Description

When launching the perception, this line makes the radar object tracker to be launched always even if there is no radar to get the output from it.

Expected behavior

use_radar_tracking_fusion should be true if and only if the radar has a role in fusion. To be more precise, the perception mode should be camera_lidar_radar_fusion, lidar_radar_fusion or radar.

Actual behavior

use_radar_tracking_fusion will always be true even if no radar has a role in fusion.

Steps to reproduce

  1. Set the perception mode to one of the lidar or camera_lidar_fusion.
  2. Launch the perception.
  3. List the topics with ros2 topic list and you see /perception/object_recognition/tracking/radar/far_objects and /perception/object_recognition/detection/radar/far_objects which are empty as there is no publisher for the latter.

Versions

No response

Possible causes

Decide to set the use_radar_tracking_fusion based on the perception mode value.

Additional context

No response

@mhmdrz-mirdamadi mhmdrz-mirdamadi changed the title radar_object_tracker launches even if no radar has been launched radar_object_tracker launches even if no radar has been launched Jun 12, 2024
@idorobotics idorobotics added the type:bug Software flaws or errors. label Jun 13, 2024
Copy link

stale bot commented Aug 12, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Aug 12, 2024
@amadeuszsz
Copy link
Contributor

amadeuszsz commented Oct 17, 2024

Seems this PR resolved this problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:stale Inactive or outdated issues. (auto-assigned) type:bug Software flaws or errors.
Projects
No open projects
Development

No branches or pull requests

3 participants