Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't generate proper route in some merging pattern #6282

Closed
3 tasks done
VRichardJP opened this issue Feb 1, 2024 · 4 comments · Fixed by #7156
Closed
3 tasks done

Can't generate proper route in some merging pattern #6282

VRichardJP opened this issue Feb 1, 2024 · 4 comments · Fixed by #7156
Assignees
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:bug Software flaws or errors.

Comments

@VRichardJP
Copy link
Contributor

VRichardJP commented Feb 1, 2024

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I'm convinced that this is not my fault but a bug.

Description

Using the planning simulator with the sample map, I have found a strange pattern in which it is either not possible to create a route or the generated route is impossible:

cannot_set_goal-2024-02-01_16.15.53.webm

For example:

  • from 0:20 to 0:30, a broken route is generated
  • from 0:30 to 0:40 then from 0:55 to 1:10, goal pose is rejected

I know looped routes are not supported, but I don't think there is any lanelet loop here. Some route lanelet may physically overlap but it should not be a problem?

Expected behavior

No problem to generate any of the routes?

Actual behavior

Autoware refuses some goals.

Steps to reproduce

planning simulator with sample map.

Versions

No response

Possible causes

No response

Additional context

No response

@VRichardJP VRichardJP added type:bug Software flaws or errors. component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Feb 1, 2024
@mehmetdogru
Copy link
Contributor

This issue is meant to be assigned to somebody by @xmfcx

@maxime-clem
Copy link
Contributor

Routing fails because of the Route Handler and its function to remove overlapping lanelets. In this case, the ego lanelet is also removed and it causes the bug.
Since the Route Handler is used in many different modules, it is hard to fix this bug without affecting the behavior of other modules.

@VRichardJP
Copy link
Contributor Author

@maxime-clem Ah yes!

I guess the best way to fix that would be to have the route handler send and update partial routes. For example, the first 500m or up to the first overlap (whichever comes first).

Copy link

stale bot commented Apr 30, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Apr 30, 2024
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label May 16, 2024
@mkquda mkquda linked a pull request May 29, 2024 that will close this issue
4 tasks
@idorobotics idorobotics moved this from Todo to In Progress in Planning & Control Working Group Jun 11, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Planning & Control Working Group Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:bug Software flaws or errors.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

7 participants